GithubHelp home page GithubHelp logo

Comments (4)

dot-asm avatar dot-asm commented on May 24, 2024 1

However I suspect that you might know faster or more elegant ways to achieve these things.

Don't be so sure:-) PR is welcomed!

from blst.

dot-asm avatar dot-asm commented on May 24, 2024 1

I wonder what the best practice is, e.g. RustCrypto's signatures crates have explicit PartialEq impl for their dsa and ecdsa crates.

Formally speaking this is not exactly a right place to pop such a question. As we are not considering ourselves as a "Rust shop." We do exercise, and one might even say advocate for minimally-required principle though. Taking this question as an example. You are not supposed to use your secret key for anything but signing, so why would it require a comparison trait? One can make a legitimate case against attaching generic traits as they make no commitments to constant-time execution, while blst does...

from blst.

sean-sn avatar sean-sn commented on May 24, 2024

Closing the issue since the merged PR resolved it

from blst.

tessico avatar tessico commented on May 24, 2024

Any reason why PartialEq was not added for SecretKey? Is this some security concern or just an omission?
I wonder what the best practice is, e.g. RustCrypto's signatures crates have explicit PartialEq impl for their dsa and ecdsa crates.

from blst.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.