Comments (4)
However I suspect that you might know faster or more elegant ways to achieve these things.
Don't be so sure:-) PR is welcomed!
from blst.
I wonder what the best practice is, e.g. RustCrypto's signatures crates have explicit
PartialEq
impl for their dsa and ecdsa crates.
Formally speaking this is not exactly a right place to pop such a question. As we are not considering ourselves as a "Rust shop." We do exercise, and one might even say advocate for minimally-required principle though. Taking this question as an example. You are not supposed to use your secret key for anything but signing, so why would it require a comparison trait? One can make a legitimate case against attaching generic traits as they make no commitments to constant-time execution, while blst does...
from blst.
Closing the issue since the merged PR resolved it
from blst.
Any reason why PartialEq
was not added for SecretKey
? Is this some security concern or just an omission?
I wonder what the best practice is, e.g. RustCrypto's signatures crates have explicit PartialEq
impl for their dsa and ecdsa crates.
from blst.
Related Issues (20)
- geth/cgo: geth build failed -std=c99 HOT 1
- Rust crate does not work with MSVC HOT 4
- Missing implementations for sqr{,x}_n_mul_mont_384x HOT 2
- Runtime detection bug on macOS HOT 1
- Versioned EIP2333 Key Generation HOT 4
- A better build system? HOT 12
- How to compile the library libblst.a for iOS platform HOT 4
- multi-exponentiation with single point is wrong HOT 2
- Portable builds fail in shared library build HOT 2
- Support `-fvisibility=hidden`, use explicit visibility attributes for both private and public symbols HOT 7
- Using the C library: exp_mont_384 is hard to use HOT 1
- Rust bindings: `std` feature used but not declared in Cargo.toml HOT 25
- Unoptimized sha256 funcs always do runtime detection HOT 4
- Update optimization level recommendation HOT 2
- LVI countermeasures in assembly HOT 1
- Rust bindings reference non-existent "std" feature HOT 3
- Error building blst Wasm in Rust HOT 2
- Windows: bool is 4-bytes by default HOT 3
- `blst` fails to build in Windows on ARM device HOT 4
- `blst` fails to build macos 13.x HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blst.