Comments (3)
unless we also increase the non-minor version
Since the crate is currently on major version 0
it is allowed to do breaking changes on minor versions:
Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
https://semver.org/#spec-item-4
from blst.
Formally speaking it's unreasonable to expect that users would have to modify their code unless we also increase the non-minor version. One can discuss that, but meanwhile why not start by suggesting an additional interface, say aggregate_iter
? This would allow us to weigh pros and cons and maybe extend the approach...
from blst.
Having a aggregate_iter
would also work, and it would allow for deprecation warnings to be put on current aggregate
if it is decided to be removed in the future.
As for how users will have to modify their code if it's replaced, I think the only scenario will be one like this:
fn test() {
let references_collection: [&usize; 4] = [&0, &0, &0, &0];
// Works
slice_of_ref(&references_collection);
// Does not work, is a IntoIterator<Item = &&usize>
into_iter_of_ref(&references_collection);
}
fn slice_of_ref(slice: &[&usize]) { }
fn into_iter_of_ref<'a>(slice: impl IntoIterator<Item = &'a usize>) { }
And can be fixed in either of these 2 ways:
// Consume collection, most likely not ideal
into_iter_of_ref(references_collection);
// Copy to remove one reference
into_iter_of_ref(references_collection.iter().copied());
This could be possibly be remedied using some other generic trait, though I don't know of such way currently, and is most likely is not possible in current rust.
from blst.
Related Issues (20)
- `blst` fails to build macos 13.x HOT 2
- Rust bindings: `PublicKey::key_validate` not linking for `x86_64-fortanix-unknown-sgx` (current master branch) HOT 11
- [Rust-binding] Proposal to implement `std::hash::Hash` for publicly exposed structures HOT 6
- BLST throws illegal instruction error on AMD K10 CPUs (Windows) HOT 27
- How Derive keys by path? HOT 2
- The same private key but different public key results HOT 2
- Segmentation fault in some machines and not in others using OpenBSD adJ74 HOT 15
- Rust bindings not recompiled on target CPU change HOT 6
- Unable to build on x86 macOS using LLVM 17.0.6 HOT 4
- When might the next release be cut? HOT 5
- ARMv7 optimization HOT 19
- Bug: Incorrect result from blst_fp_inverse()
- Failed to build with `undefined: Message` HOT 1
- Rust bindings broken on Mac Sonoma 14.5. HOT 2
- RISC-V compilation? HOT 5
- PT constructor with node.js binding HOT 1
- `aggregate_verify` no longer accessible targetting `wasm32-unknown-unknown` HOT 5
- how to sign a msg hash instead of msg with rust bindings? HOT 3
- Integration to `conda-forge` - issue with mac build HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blst.