Feature: Limit number of concurrent futures when fetching remote records about surrealdb

[meetwithyash]

@ceelias @tobiemh , I have made the changes like the following, Please let me know if it is correct or any other changes needed.

Changes inside file: get.rs

Changes inside file: del.rs

Changes inside file: set.rs

[tobiemh]

@meetwithyash are you working on this? If not I'd like to pick this one up

That would be awesome @ceelias!

[meetwithyash]

@tobiemh , Okay I will update it and raise a pull request!

[meetwithyash]

@tobiemh , I am looking to contribute, Can I work on this one?

[tobiemh]

Hey @meetwithyash sorry I missed your comment! Absolutely - any contributions would be amazing 😀👍🚀 !

[ceelias]

@meetwithyash are you working on this? If not I'd like to pick this one up

[tobiemh]

Awesome @meetwithyash! I know I originally mentioned buffer_unordered but I think it's probably better if we use buffered here, to ensure that the results are returned in the same order that they are retrieved (but still fetched concurrently).

[meetwithyash]

@tobiemh , Please check the above pull request #1346 , and please let me know if anything else needed to be updated.

[ceelias]

@meetwithyash Looks like you are working on this, ill look for something else to pick up.

I did look at your change though and I think there are some other changes are needed.

You will need to remove the import for try_join_all as suggested in the github action warning in addition to importing buffered()
I think the right import is:

use futures::stream::{StreamExt};

Also, buffered() is creating a stream/list of futures so I think you will need to collect() them in order for them to be awaited.
I'm pretty new to Rust though so take my advice with a grain of salt 😄

[suhailmalik07]

After modifying as @ceelias described.
Changes:

// try_join_all(futs).await.map(Into::into)

futures::stream::iter(futs)
	.buffered(10)
	.try_collect::<Vec<_>>()
	.await.map(Into::into)

I'm getting this error from async_recursion.

higher-ranked lifetime error
could not prove `for<'r, 's, 't0, 't1, 't2, 't3, 't4, 't5, 't6, 't7, 't8, 't9, 't10> Pin<Box<impl for<'r, 's, 't0, 't1, 't2, 't3, 't4, 't5, 't6, 't7, 't8, 't9> futures::Future<Output = Result<sql::value::value::Value, err::Error>>>>: CoerceUnsized<Pin<Box<(dyn futures::Future<Output = Result<sql::value::value::Value, err::Error>> + std::marker::Send + 't10)>>>`rustc`

If anyone can help or point me to right direction that will be great.