GithubHelp home page GithubHelp logo

Comments (9)

SURYAKANTSHARMA avatar SURYAKANTSHARMA commented on June 14, 2024 1

@dhritzkiv read me already updated please check https://github.com/SURYAKANTSHARMA/CountryPicker#readme cc @Sharkesm
between why you need instance at first place ?

there is other function for that if you need manual presentation on your navigation etc

 CountryPickerWithSectionViewController.presentController(on: self, configuration: { countryController in
            // You can still capture here in you need to but not recommended 
        }) { [weak self] country in
            
          
        }

from countrypicker.

SURYAKANTSHARMA avatar SURYAKANTSHARMA commented on June 14, 2024 1

use countryController. configuration.detailFont will update major version.

from countrypicker.

Sharkesm avatar Sharkesm commented on June 14, 2024 1

@dhritzkiv Updated the README file on the styling section. Please confirm as to whether the styling configuration is exposed for the current version or else we may proceed to close this thread.

cc/ @SURYAKANTSHARMA

from countrypicker.

Sharkesm avatar Sharkesm commented on June 14, 2024

@dhritzkiv Good point that you raised.

@SURYAKANTSHARMA Could we proceed with updating the README based on the recent changes that you made.

from countrypicker.

SURYAKANTSHARMA avatar SURYAKANTSHARMA commented on June 14, 2024

@Sharkesm should we close this or do you want me to upgrade the version ?

from countrypicker.

dhritzkiv avatar dhritzkiv commented on June 14, 2024

In 1.3.2 I was doing this:

let countryController = CountryPickerWithSectionViewController.presentController(on: self) { [weak self] (country: Country) in
    // code
}

countryController.title = "" // custom title

countryController.detailFont = UIFont.systemFont(ofSize: 17)
countryController.detailColor = UIColor.systemGray
countryController.labelFont = UIFont.systemFont(ofSize: 17)
countryController.labelColor = UIColor.systemGray

countryController.flagStyle = .corner

I'm unable to apply these in the configuration block

from countrypicker.

Sharkesm avatar Sharkesm commented on June 14, 2024

@dhritzkiv I think you can still apply the configuration of the controller as instructed on the README file.

@SURYAKANTSHARMA For that case since there's code-breaking would be best to update the versioning to avoid any confusion and cross-check the styling section of the README file as well.

from countrypicker.

dhritzkiv avatar dhritzkiv commented on June 14, 2024

It doesn't look to be the case. More than just that API changed:

image

from countrypicker.

SURYAKANTSHARMA avatar SURYAKANTSHARMA commented on June 14, 2024

I have not delete live version as per this. but had updated new version will reflect soon 2.0.0

from countrypicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.