Comments (9)
@dhritzkiv read me already updated please check https://github.com/SURYAKANTSHARMA/CountryPicker#readme cc @Sharkesm
between why you need instance at first place ?
there is other function for that if you need manual presentation on your navigation etc
CountryPickerWithSectionViewController.presentController(on: self, configuration: { countryController in
// You can still capture here in you need to but not recommended
}) { [weak self] country in
}
from countrypicker.
use countryController. configuration.detailFont
will update major version.
from countrypicker.
@dhritzkiv Updated the README file on the styling section. Please confirm as to whether the styling configuration is exposed for the current version or else we may proceed to close this thread.
cc/ @SURYAKANTSHARMA
from countrypicker.
@dhritzkiv Good point that you raised.
@SURYAKANTSHARMA Could we proceed with updating the README based on the recent changes that you made.
from countrypicker.
@Sharkesm should we close this or do you want me to upgrade the version ?
from countrypicker.
In 1.3.2 I was doing this:
let countryController = CountryPickerWithSectionViewController.presentController(on: self) { [weak self] (country: Country) in
// code
}
countryController.title = "" // custom title
countryController.detailFont = UIFont.systemFont(ofSize: 17)
countryController.detailColor = UIColor.systemGray
countryController.labelFont = UIFont.systemFont(ofSize: 17)
countryController.labelColor = UIColor.systemGray
countryController.flagStyle = .corner
I'm unable to apply these in the configuration block
from countrypicker.
@dhritzkiv I think you can still apply the configuration of the controller as instructed on the README file.
@SURYAKANTSHARMA For that case since there's code-breaking would be best to update the versioning to avoid any confusion and cross-check the styling section of the README file as well.
from countrypicker.
It doesn't look to be the case. More than just that API changed:
from countrypicker.
I have not delete live version as per this. but had updated new version will reflect soon 2.0.0
from countrypicker.
Related Issues (20)
- Improve Dark Mode UI HOT 1
- List is Empty HOT 2
- Selecting while search HOT 3
- fatalError in Country.swift HOT 2
- Getting flag from country code HOT 3
- Memory Leak HOT 2
- Selected country localisation issue. HOT 2
- Wrong country for code "7". HOT 4
- More customization of countries list HOT 2
- localising the country list based on application and not based on device language HOT 3
- Γ land islands, Cayman islands, Jamaica possibly wrong phone codes HOT 5
- Mac Catalyst Support HOT 2
- Using of custom CountryListDataSource doesn't prevent the call of CountryManager.shared `allCountries` method HOT 1
- A way of setting the last selected country HOT 5
- EXC_BREAKPOINT Swift runtime failure: Index out of range HOT 1
- Unable to see check / tick mark for selected country HOT 5
- Searchbar Customization HOT 1
- Add/Remove country HOT 1
- Localization HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from countrypicker.