Comments (6)
In general I agree with you, I just did not want to optimize these things too early and too much as we have currently only 2 openstackclient
commands covered.
from cct.
Yes, but I'd need project
now and the necessary code for introducing openstack project list
or show
functionality would be only duplication.
Those to sub-commands should be inherited from some parent class, don't you think?
from cct.
Or module that is included into the context. We're already including NodeContext
into the commands classes, we might add them there (or into a new module that is included into the NodeContext
): https://github.com/SUSE-Cloud/cct/blob/master/lib/cct/commands/openstack.rb#L22
Or would you rather convert that module into a class and inherit from it for every openstackclient
command (I mean here this class: https://github.com/SUSE-Cloud/cct/blob/master/lib/cct/commands/openstack/user.rb#L4) ?
from cct.
Puh, that's a design questions on which I don't have any particular opinion.
from cct.
This is the proposal to simpify the commands' implementation: Add openstack client refactored api
from cct.
Thanks for improving this right away!
Edit: I just saw the PR isn't merged yet but I keep this issue closed as this will eventually go into master.
from cct.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cct.