GithubHelp home page GithubHelp logo

Comments (6)

svaarala avatar svaarala commented on June 17, 2024

Yeah, looks like a bug. The intent is indeed to resolve to foo/quux.

The https://github.com/svaarala/duktape/blob/master/ecmascript-testcases/test-commonjs-require-resolution.js testcase tries to cover this and has a relative resolution test. I'll check if there's a bug in the testcase itself because it passes.

from duktape.

svaarala avatar svaarala commented on June 17, 2024

The code tries first to form an intermediate form in resolution and then normalize it. Currently this form was:

foo/bar/./quux

which is clearly incorrect. The proper starting point is:

foo/bar/.././quux

which normalizes to the desired result foo/quux.

from duktape.

svaarala avatar svaarala commented on June 17, 2024

And yes, the testcases were testing for the wrong behavior :-)

from duktape.

svaarala avatar svaarala commented on June 17, 2024

This merge should fix the issue: 3358df2

from duktape.

andoma avatar andoma commented on June 17, 2024

Yep, works fine in my environment. Thanks for excellent support (as usual :-)

from duktape.

svaarala avatar svaarala commented on June 17, 2024

You're welcome :)

from duktape.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.