Comments (16)
@abitsalihu you are good to go I am assigning on this!
from geeksay.
@dk3775 I would like to work on this issue :)
from geeksay.
@dk3775 I finished this issue, but I think I made a mistake to what should be copied. I made the copy button to copy the random quote that is generated or should it copy the : Random Translation: (this part that is inside here) ?
If you could tell me if i did it correctly or I should make changes so I can move on with the PR. :)
Below is the video of how I made it:
Screen.Recording.2022-09-19.at.14.00.39.mov
from geeksay.
@dk3775 I read the Issue again, and I think I understand what needed to be copied (the translated quote that is generated from the random quote)!
Below is a video of how the "copy button" works now:
Please tell me if this is correct so I can go ahead and make a PR.
Screen.Recording.2022-09-19.at.14.20.02.mov
from geeksay.
@abitsalihu bro actually we had to copy whatever text is there in translated textbox, I guess just changing the js object will do the needful.
Hope you understood that, else just ping me again anytime!!
from geeksay.
@dk3775 I already made a PR yesterday, can you please check it out and tell me what's wrong.
There is a video attached with it to see how it works!
from geeksay.
@abitsalihu ooh my bad I didn't check it correctly it's working perfectly fine, thanks!
from geeksay.
@dk3775 please check the latest commit I did on the PR. :)
from geeksay.
Hello @abitsalihu you did great work adding that button,
Still I think we need better styling to the button.
from geeksay.
@abitsalihu thank you, I styled it the same as the random button
as I was told so. :)
from geeksay.
@abitsalihu I know but now think it does not go with the flow :-|
from geeksay.
Hi @dk3775 I am working on the copy button trying to make it a little bit better. I am improving the alert and trying to make the copy button look more natural to the page.
from geeksay.
hey! I would like to work on this issue
from geeksay.
Hi @aharna
Well I have made a version of copy button and made a PR. Still both of us will have to wait for @dk3775 for his reponse.
from geeksay.
Hello @RohanTheProgrammer the button looks fine in desktop view, but mobile view needs to be fixed. Just make it dynamic.
Anyone else can also contribute to PR #369 on this issue.
from geeksay.
This issue is solved by #369 from @RohanTheProgrammer. And is now closed.
from geeksay.
Related Issues (20)
- Chrome extension, that will translate page to geek HOT 9
- Some experience with the project HOT 1
- Text overflows HOT 1
- Ferl HOT 1
- Two word translations not working HOT 5
- No copy to clipboard button HOT 1
- No copy to clipboard button HOT 8
- New system/form for adding new Quotes and Translations HOT 14
- Improve the Mobile Responsive Version HOT 21
- BUTTON RANDOM QUOTE AND COPY QUOTE NOT WORKING HOT 3
- Translation issue while reading numeric values HOT 5
- Update Readme.md for better styling. HOT 6
- Typo preventing buttons to function HOT 1
- I want to update the regular function with the arrow functions. HOT 3
- UI enhancement HOT 7
- 'node_modules' is not recognized as an internal or external command, HOT 1
- gallery addition HOT 2
- feat(Hactober Fest 2023) - Added a cool quote and a translation used in it
- Share button not displaying. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geeksay.