Retrieve channel to perform manual action on a queue about swarrotbundle

[odolbeau]

Adding a getChannel method in the FactoryInterface is not a good idea as this concept is specific to RabbitMQ. If you use Redis for example, this method is not implementable.
Furthermore, your getChannel won't return the same class in all implementations.

I see 2 solutions here.

Solution 1:

In the PeclFactory you can use the getQueue public method to achieve your need.
Changing the visibility of the getChannel method in the AmqpLibFactory could be a way to retrieve the number of messages.
This solution is abviously a hack. You won't be able to switch between implementations.

Solution 2:

The cleanest solution is probably to add a getMessageCount method (or something like this) into the MessageProviderInterface (directly in swarrot library).

It looks like it's easy to implement for SQS as there is a method to retrieve the approximative number of messages in a queue (see here).

For both Pecl & AmqpLib implementations, it looks like it's possible to retrieve the amount of messages using 2 different ways:

• by declaring the queue (see pecl & amqplib): this isn't a perfect solution as it's probably throw an Exception when you try to create a queue without the same config (when it already exists) or when you don't have enough permissions to create queues.
• as you said: by retrieving a message. Again, that's for from perfect, as it means this message needs to be consumed after (which is far from easy).

None of those implementations are perfect unfortunately.

At the end, I don't have any clean solution for your need... :/

The first solution is definitively the easiest to implement but it means you won't be able to easily switch from an implementation to another if you need to.
The second one is cleaner but way harder to implement... (I'm not even sure it's possible! :o)

WDYT?

[j0k3r]

Thanks for all these explanations 👍

I noticed the getQueue after posting my issue.
But I'm using amqp lib atm (didn't took time to compile the pecl extension).

I agree the second solution looks cleaner but more complex.
I'll go with the first solution.

So should I just open a PR with that?

    /**
     * getChannel.
     *
     * @param string $connection
     *
     * @return AMQPChannel
     */
-   protected function getChannel($connection)
+   public function getChannel($connection)

[odolbeau]

Yes, it looks fine for me.

[odolbeau]

May I ask you what's your need exactly? :)

[j0k3r]

I have a command that push thousand messages in a queue every 10 minutes.
I would like that command to check if the queue is empty (or have less than XX messages) before sending again new messages.

See j0k3r/banditore#37 🙂

[odolbeau]

Thanks. :)