GithubHelp home page GithubHelp logo

Comments (10)

callo90 avatar callo90 commented on May 18, 2024 1

Hey I found the issue, this is the scenario:

  1. I have two types of cell, first one extends from SwipeTableViewCell, the second one extends from UITableViewCell

  2. tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) not working.

  3. Now extending the second cell from SwipeTableViewCell

  4. tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) now working

I will check this in the code if you want, it shouldn't affect the behavior of the tableview.

from swipecellkit.

kurabi avatar kurabi commented on May 18, 2024 1

Fixed in commit 73ff931

from swipecellkit.

jerkoch avatar jerkoch commented on May 18, 2024

Hi @callo90 - I have not run into this. 🤔

Can you provide a simple project demonstrating the issue?

from swipecellkit.

jerkoch avatar jerkoch commented on May 18, 2024

Hey @callo90 - It works for me when I add the didSelectRowAt callback to the MailExample. Can you attach your code?

from swipecellkit.

AnasMostefaoui avatar AnasMostefaoui commented on May 18, 2024

Hi guys
I had similar issue with didSelect, since I'm using GenericDataSource pod to manage my collections, adding didSelectRowAt was not an option.

my current work arround is to disable the tapGestureRecognizer.
What is the side effect of doing such thing ? I did try it and selecting actions is working

thanks

from swipecellkit.

jerkoch avatar jerkoch commented on May 18, 2024

Hi @AnasMostefaoui - The tap gesture recognizer is used by the active cell to dismiss itself when tapping occurs in the content view area instead of the action buttons.

from swipecellkit.

HarithaNaveen avatar HarithaNaveen commented on May 18, 2024

Hi @callo90, Facing the same issue that you have mentioned. Having two different types of cells in a tableView. One extending SwipeTableViewCell, and another extending UITableViewCell, didSelectRow is not called. But when I tried extending the other cell also from SwipeTableViewCell, it worked.
Thanks.

from swipecellkit.

AaronBertsch avatar AaronBertsch commented on May 18, 2024

Hi @callo90, had the same issues as well and extending all cells used in the table to SwipeTableViewCell worked.

@jerkoch A couple things I noticed that may help find the issue:
It seemed to only effect the first few rows, not sure it is was a percent thing or a specific number of rows, but if I scrolled the first item to the top so about half of the cell was showing, then the didSelectRowAt would fire while tapping on it.
Also, rows longer down the table view would also fire, it seemed to be about the first 6-7 rows that wouldn't unless they were scrolled up/down.

Thanks for the awesome cells btw :-)

from swipecellkit.

nebyark avatar nebyark commented on May 18, 2024

I'm seeing the same issue. The table view I'm working with has a few different custom table view cells (one of them being the SwipeTableViewCell). If the only cells visible on the screen were SwipeTableViewCells, then the didSelectRowAt method would fire without any problems-- otherwise, the delegate method would only fire intermittently on a long press.

Setting cancelsTouchesInView on the tapGestureRecognizer property in SwipeTableViewCell allowed the tap to pass through, which in turn fired the didSelectRowAt method (even when multiple custom cells were being displayed)-- but now I'm seeing issues where not all of my swipe action selectors are being fired.

from swipecellkit.

kurabi avatar kurabi commented on May 18, 2024

Found the bug and have a fix, will commit fix tonight.

from swipecellkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.