GithubHelp home page GithubHelp logo

Comments (3)

sylvainlaurent avatar sylvainlaurent commented on June 26, 2024

it would require to use ANTLR to correctly parse SQL statement...�

from jdbc-performance-logger.

samyBadjoudj avatar samyBadjoudj commented on June 26, 2024

the pull request #71 should take care of that. Without implementing a full parser with tokens.
It removes comments before letting the fillParameters method doing the job.

NB:
The filled sql, will not have the comment but RDBMSes hints (Mysql and Oracle) will be kept in the filledSql.
https://docs.oracle.com/cd/E11882_01/server.112/e41573/hintsref.htm#PFGRF005

But the code will manage even inner comments in the sql statements like those
PreparedStatement stmnt = con.prepareStatement(" UPDATE /*blah = ? */ TBL SET col1 = ? ")

Hope it helped

from jdbc-performance-logger.

sylvainlaurent avatar sylvainlaurent commented on June 26, 2024

fixed by merging PR #72

from jdbc-performance-logger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.