Comments (6)
I created a pull request in YosysHQ/sby#18.
It works for me, but might not be the correct solution.
from riscv-formal.
I don't know what "exercise 1" refers to. But I'm certain YosysHQ/sby#18. just breaks the tool and doesn't help in any way.
from riscv-formal.
Ah, apparently "exercise 1" refers to the quickstart guide.
Since you did not post anything that would allow me to reproduce whatever you are seeing, I can only assume that the check passed (because either you didn't change the core, or changed it in a way that had no negative effect), and a passing test of course doesn't produce a counter example trace.
from riscv-formal.
Thanks for the quick reply. Yes, I was referring to the quickstart guide, sorry for not mentioning this.
I did change the core and one test failed.
I changed the core now at a different point and now the trace is generated. This difference is that in the previous failed test, it already stopped at "Warmup failed!". I guess this is a point where there are no traces which can be generated.
from riscv-formal.
it already stopped at "Warmup failed!". I guess this is a point where there are no traces which can be generated.
yes. I don't know which check exactly failed for you and why of course, but the general idea behind "Warmup failed" is like this: Say you have a check that makes sure that the addi
instruction does the right thing. Now you make a change that entirely prevents the core from every handling an addi
instruction. This will make the check fail, but there is no counter-example trace showing that the addi
instruction is handled incorrectly because there is not even any trace that has the core retiring an addi
instructions, correctly or incorrectly.
In more formal terms: If the "warmup check" is enabled (which is the case by default in smt-based symbiyosys flows), then "warmup failed" indicates that no trace satisfying the assumptions exists. (Without the "warump check" those tests pass because the assertions are trivially true if there is a contradiction in your assumptions.)
from riscv-formal.
Now you make a change that entirely prevents the core from every handling an
addi
instruction.
That is exactly what I did at first. Thanks a lot for the thorough explanation!
from riscv-formal.
Related Issues (20)
- Adding support for a newRISC-V processor to riscv-formal HOT 4
- Failed Checks in picorv32 Verification Following Quickstart Guide HOT 3
- Misaligned JAL(R) RD register writeback expectations HOT 4
- JAL handling procedure HOT 1
- Value of rs1 during CSR*I instructions HOT 2
- OOPS forget i said anything
- Incorrect width of insn_funct6 in I-type (shift variation) instruction format?
- Debug modelling
- "ERROR: syntax error, unexpected TOK_RAND" in quick start guide HOT 2
- Instruction checks: non-universal assertions should be generated based on instruction type
- How to set values in the genchecks.cfg file?
- Support for Zce?
- When is rvfi_halt supposed to be used?
- rvfi_reg_check is possibly broken (picorv32 also fails the assertion) HOT 3
- Can WARL read-only be handled in csrw_check?
- are rvfi_valid and rvfi_trap mutually exclusive.
- Some confusion about skip option
- Is this repo no longer active?
- syntax error in quickstart HOT 1
- RV32I and RV64I
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riscv-formal.