GithubHelp home page GithubHelp logo

[Tests] Polyfills not loaded about polyfill HOT 5 OPEN

IonBazan avatar IonBazan commented on July 29, 2024
[Tests] Polyfills not loaded

from polyfill.

Comments (5)

nicolas-grekas avatar nicolas-grekas commented on July 29, 2024

That's how it's supposed to work to me: the internal function (the native one, non-polyfilled) is not found since you're on PHP 8.1
Try running this on PHP 8.3, it should be green.

from polyfill.

IonBazan avatar IonBazan commented on July 29, 2024

That doesn't make much sense to me. From what I remember, we were including bootstrap.php files using TestListenerTrait which made sure the function is registered globally - this is to use same test code on PHP 8.1 and 8.3 and compare results between polyfilled and native implementation.

from polyfill.

IonBazan avatar IonBazan commented on July 29, 2024

OK, I think I got it now - I always thought we run the future-compatible tests on old versions too, and that the functions are globally registered but now I see the mechanism is much more sophisticated. I just wonder if that won't produce any regressions, as we test json_validate only on PHP 8.3 and up, we could technically put some new syntax which is not compatible with older versions and still observe a green CI 🤔

from polyfill.

stof avatar stof commented on July 29, 2024

Aren't we testing the polyfill variant on all PHP versions ?

from polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.