GithubHelp home page GithubHelp logo

Comments (3)

qdequippe avatar qdequippe commented on July 26, 2024 1

+1
The result of $mailer->send($message) is always equals to 1 even if Swift_TransportException is raised. It's a big problem for us because we can't check if the email is really sent or not.

What do you think about (re)throw the exception with the log as below (https://github.com/symfony/swiftmailer-bundle/blob/master/EventListener/EmailSenderListener.php#L62):

try {
    $spool->flushQueue($this->container->get(sprintf('swiftmailer.mailer.%s.transport.real', $name)));
} catch (\Swift_TransportException $exception) {
    if (null !== $this->logger) {
         $this->logger->error(sprintf('Exception occurred while flushing email queue: %s', $exception->getMessage()));
     }
     throw $exception;
}

from swiftmailer-bundle.

romaricdrigon avatar romaricdrigon commented on July 26, 2024

+1 for doing something/anything to improve the situation: at the moment, those exceptions won't be logged; but will crash the profiler so you don't see anything in Symfony2 debug toolbar.

edit: it seems a logger was introduced since this issue; but for some reason, it is not enabled by default, as the previous behavior of crashing profiler happens with 2.6 and 2.7.

from swiftmailer-bundle.

fabpot avatar fabpot commented on July 26, 2024

Closing old issues.

from swiftmailer-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.