GithubHelp home page GithubHelp logo

Comments (6)

KrisThielemans avatar KrisThielemans commented on August 29, 2024

Hi. this file comes from parallelproj, specifically https://github.com/gschramm/parallelproj/blob/master/c/include/parallelproj_c.h. It looks fine there. Could you check versions etc?

from sirf-superbuild.

samdporter avatar samdporter commented on August 29, 2024

Old version of parallelproj (v1.0.0)
Shall I close?

from sirf-superbuild.

KrisThielemans avatar KrisThielemans commented on August 29, 2024

did it give STIR compilation problems? Maybe only with the TOF branch? If not, we could raise the parallelproj minimum version in STIR's CMakeLists.txt, and even the SIRF-SuperBuild's version_config.cmake.

(I guess SIRF never sees parallelproj itself, so not sure if this issue was in the right place).

from sirf-superbuild.

samdporter avatar samdporter commented on August 29, 2024

Yes, it gave STIR compilation problems on the master branch

from sirf-superbuild.

KrisThielemans avatar KrisThielemans commented on August 29, 2024

ok. Please check in which version of parallelproj this was fixed and generate a PR on STIR at https://github.com/UCL/STIR/blob/ea105a0ce2299afe2e598f249ecbe69de988b7c2/CMakeLists.txt#L200 accordingly and the SIRF-SuperBuild at

set(parallelproj_REQUIRED_VERSION "1.0")
.

I'll transfer this issue

from sirf-superbuild.

KrisThielemans avatar KrisThielemans commented on August 29, 2024

This was fixed in parallelproj 1.0.1. STIR now requires that. I think we can just close this here.

from sirf-superbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.