v2.0.0-beta1 panic about aws-sso-cli

[mouchar]

Confirmed, binary built from the current v2 branch works fine and recreates the cache file if it doesn't exist. Panic doesn't happen.

[synfinatic]

pretty sure this bug is fixed in the v2 branch already... care to try? You can build yourself or here's a preview build of beta2
aws-sso-2.0.0-beta2-linux-amd64.gz

[mouchar]

Unfortunately, the issue persists even with the build aws-sso-2.0.0-beta2-linux-amd64.gz you provided:

/tmp/aws-sso-2.0.0-beta2-linux-amd64 login -L trace -u printurl --sts-refresh
INFO    open /home/REDACTED/.aws-sso/cache.json: no such file or directory 
DEBUG   loading SSO using 10 retries and max 5sec backoff 
INFO    You are already logged in. :)                
DEBUG   Checking the current active accounts vs. our cache 
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xa139cf]

goroutine 1 [running]:
github.com/synfinatic/aws-sso-cli/sso.(*SSOCache).NeedsRefresh(...)
	github.com/synfinatic/aws-sso-cli/sso/cache.go:132
main.(*LoginCmd).Run(0xc00023ac80, 0xc00023f980)
	github.com/synfinatic/aws-sso-cli/cmd/aws-sso/login_cmd.go:45 +0x18f
reflect.Value.call({0xa92700?, 0xc00023ac80?, 0xb58860?}, {0xb59fac, 0x4}, {0xc0004491b8, 0x1, 0x0?})
	reflect/value.go:596 +0xce7
reflect.Value.Call({0xa92700?, 0xc00023ac80?, 0xaadce0?}, {0xc0004491b8?, 0xb58860?, 0x0?})
	reflect/value.go:380 +0xb9
github.com/alecthomas/kong.callFunction({0xa92700?, 0xc00023ac80?, 0x0?}, 0xb59a6b?)
	github.com/alecthomas/[email protected]/callbacks.go:98 +0x40b
github.com/alecthomas/kong.(*Context).RunNode(0xc00023f600, 0xc00024e690, {0xc00037fe08, 0x1, 0x0?})
	github.com/alecthomas/[email protected]/context.go:765 +0x810
github.com/alecthomas/kong.(*Context).Run(0xc00032c5b0?, {0xc00037fe08?, 0x0?, 0x0?})
	github.com/alecthomas/[email protected]/context.go:790 +0x132
main.main()
	github.com/synfinatic/aws-sso-cli/cmd/aws-sso/main.go:219 +0xbae

But stack trace is slightly different.

The easiest reproducer is to delete cache.json and run aws-sso login

[synfinatic]

thanks, that's helpful.

[synfinatic]

Should work now. Uploading aws-sso-2.0.0-beta2-linux-amd64.gz…