Connection won't work for federated data sources about document-api-python

[t8y8]

I did a little more thinking about this.

The problem is that a datasource, post 10, can contain multiple connections, so the interface for Datasouce that returns a single item is no longer valid.

I think we could extend Datasource.connection to return a list if there's more than one connection, and behave the old way if there is only one, or always operate on lists for consistency, that's a good question for debate.

My idea is to create a new class that encapsulates the 10 and pre 10 differences. DatasourceParser or ConnectionParser I'm not sure yet.

Once my tests are checked in I can add a 10 workbook to the suite and start trying a few things.

[mpope-tableau]

The example we have for updating connection information in a workbook implies that there can be multiple ones:

sourceWB.datasources[0].connection.server = "MY-NEW-SERVER"

Or am I misunderstanding your point?

[t8y8]

There can be multiple datasources, which we index to 0 -- but in 10, that datasource can have multiple connections, so it'd need to be sourceWB.datasources[0].connection[0].server = "MY-NEW-SERVER"

[mpope-tableau]

Got it.

[t8y8]

This XPath query will get all connection nodes that we care about (ignoring the connection 'federated' class): ds.findall('.//named-connections/named-connection/*')

We could extend the connections property to check the DS version and, if V10, instead call that XPath and return a list of connections. Ideally that could just be a new class and we can call 'get_connections()' but that's a refactor that could happen later.

What I don't know is if you have to update the connection element AND the named-connection element.. or at least the caption. @benlower or @LGraber know anyone who might know?

[benlower]

closing this. addressed in PR @ #10