Pagination example fails when there are fewer objects than page size about github-php-client

[ryandesign]

This workaround works for me for now:

--- README.md.orig  2016-08-13 23:51:58.000000000 -0500
+++ README.md   2016-08-15 15:24:53.000000000 -0500
@@ -134,7 +134,8 @@
    $client->setPageSize($pageSize);

    $commits = $client->repos->commits->listCommitsOnRepository($owner, $repo);
-   while(true)
+   $client->setPage();
+   while(count($commits))
    {
        $page = $client->getPage();
        echo "================ Page $page - " . count($commits) . " items ================\n";

[tan-tan-kanarek]

Thank you, could you please open a pull-request with this fix?

[ryandesign]

Is this really the fix you recommend? I was just using it as a workaround until you could work out the correct solution. I don't know your code well enough to understand how you intended it to work, but it doesn't seem right that I should have to call $client->setPage();, then issue the request, which clears page, then have to call $client->setPage(); a second time. Why does running the request clear page?

[tan-tan-kanarek]

You're right, see my fix:
#108

[tan-tan-kanarek]

Wait, it's not good, will get back to you.

[tan-tan-kanarek]

Now it's good: #109