Lua memory.writebyte() partially broken for SXROM variant of MMC1 about fceux

[zeromus]

lua's memory_writebyte should not work through the cheat API. That's stupid. I don't even want to trace through all that crap. It should go straight to the <0x10000 check and BWrite.
It seems all our packed-in scripts use it for accessing memory only so they wouldn't even notice we made the change.
@vadosnaprimer can you confirm you agree that this logic in fceux predates any sense of best practices and needs to be revised to work as memorydomain systembus would rather than this weird broken mess?
We would need to update the docs too

[vadosnaprimer]

I don't remember anything about memory writing other than it's implemented in a super complicated manner. I can't have an opinion without diving into it again, for which I just don't have time right now :(

[zeromus]

Mainly I meant, if it works any way other than as systembus, do you think it's a good idea to change it or are you willing to say "meh, whatever it did before, who cares.. it should work like systembus"

[vadosnaprimer]

The problem is I haven't seriously used either approach so in addition to no opinion I also have no experience here. Having an option would be the best but we don't include memory domain as an argument to lua mem access IIRC.

[zeromus]

OK, let's change the memory functions to work like systembus (that is go through BWrite and ARead directly) and then add legacymemory functions which work the same as the current memory functions; and update the docs. @Andypro1 if you can do that, then I'll work with you on merging it.

[Andypro1]

Sure. Does this look like it will work?

ffcc6c0

The memory read functions did not use the cheat engine, so only the write function needed a legacy implementation.

I have tested memory_writebyte() and memory.legacywritebyte() in the lua console and they both seem to behave as expected.

If this looks okay to you, I can submit it as a pull request.

[zeromus]

looks okay to me

[Andypro1]

Pull request #67 sent.

[bbbradsmith]

Pull request merged.