Comments (3)
Good progress on this in commit #96. A lot of issues were found and fixed (#98, #100). We also ended up ignoring the autogenerated apis/services.go (#100).
There's a few extra enables still needed besides the main ones:
--enable=varcheck --enable=aligncheck --enable=errcheck --enable=ineffassign --enable=unconvert -enable=goimports --enable=unused
And go fmt is still missing.
Also, @djmitche, are we okay ignoring these other files in the apis directory?
doc.go provider.go
and I imagine I should close this an open another issue for the rest...
from taskcluster-cli.
I'm not thrilled about it, but it seems to be a limit of gometalinter, so we'll survive.
Let's hold off adding more checkers for the moment -- I think the incremental value we get from them will be minimal right now, and we'll get a better value by adding more test code.
from taskcluster-cli.
Sounds good, I was thinking those would be back-burner issues but didn't want to forget them either
from taskcluster-cli.
Related Issues (20)
- Golinter warnings on status.go HOT 2
- u.Hostname undefined HOT 3
- APIs accepting continuation tokens don't work HOT 1
- Put releases in the index by their version, too HOT 1
- `taskcluster signin` fails to open browser on OS X HOT 14
- Taskcluster signin doesn't have a "Grant Credentials" section on Windows HOT 8
- Update meta-linter config HOT 3
- Fix taskcluster shell in git-bash on windows
- fix output from browser in `taskcluster signin` HOT 1
- Using taskcluster-cli cleanly within multiple shells HOT 2
- taskcluster signin not working on Windows HOT 4
- Creation of new client during taskcluster signin hangs after clicking "Create client" with "Connecting to localhost...", at least in Ubuntu VM HOT 3
- `taskcluster signin` server hangs before sending response HOT 1
- add a confirmation option to eliminate taskid and taskgroupid typos HOT 14
- Fail if TASKCLUSTER_ACCESS_TOKEN is set, but TASKCLUSTER_CLIENT_ID is empty HOT 3
- Running make updates vendor.json HOT 4
- All commands should accept TASKCLUSTER_ROOT_URL HOT 2
- Error messages should print on stderr, not stdout HOT 2
- taskcluster-cli should be installable through go get HOT 3
- CODE_OF_CONDUCT.md isn't correct HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from taskcluster-cli.