Reviews for stage 3 sign off about proposal-string-left-right-trim

[ljharb]

That's exactly what it's saying already; I agree that making the wording match the existing cases of this pattern would be better.

[evilpie]

Okay, I guess I will prepare a PR for this wording change.

[mathiasbynens]

I’d like to have clarification about the name of the aliased methods. According to the proposal’s README the String.prototype.trimLeft.name should be 'trimStart', but the currently proposed spec text doesn’t make that happen.

+@sebmarkbage @evilpie @ljharb

[sebmarkbage]

The intention is that the spec ensures this by only defining trimStart/trimEnd. The aliases defined in annex B has the same object instance and therefore has to have the same name. Although I agree that it is not very clear.

[mathiasbynens]

I believe the current spec does not suffice normatively, because of https://tc39.github.io/ecma262/#sec-ecmascript-standard-built-in-objects:

Every built-in function object, including constructors, that is not identified as an anonymous function has a name property whose value is a String. Unless otherwise specified, this value is the name that is given to the function in this specification. For functions that are specified as properties of objects, the name value is the property name string used to access the function.

[ljharb]

I think it does suffice; because the Start variants are defined first, with the Start names; and then later, in annex b, the Left variants are aliases to the pre-existing Start objects. This works for Array.prototype.values/Symbol.iterator, for example.

However, it might be a good idea to add explicit sentences in the Left variants indicating that their names are the Start variants.

[leobalter]

Can I suggest we reuse the language for Array#@@iterator?

The initial value of the @@iterator property is the same function object as the initial value of the Array.prototype.values property.

This would be an editorial change only in the proposal, so it shouldn't affect any in the stage process or merging it to the specs.

[evilpie]

See #25