GithubHelp home page GithubHelp logo

Comments (3)

fkjctm avatar fkjctm commented on September 2, 2024

I think the problem is in the rule implementation:

const lint = function(packageJsonData, severity) {
  const rangeSpecifier = '^';

  if (packageJsonData.hasOwnProperty(nodeName) && areVersRangesValid(packageJsonData, nodeName, rangeSpecifier)) {
    return new LintIssue(lintId, severity, nodeName, message);
  }

  return true;
};

If will only return the LintIssue if areVersRangesValid returns true. But that function will only return true if ALL the dependencies contain the caret. I want an error if ANY of the dependencies have the caret. It looks like the tilde and devDependencies of this have the same behavior.

If I have time. I'll try to get a PR together for it.

from npm-package-json-lint.

fkjctm avatar fkjctm commented on September 2, 2024

It turns out prefer-absolute-version-dependencies and prefer-absolute-version-devDependencies will accomplish what I need to do. So, I'll close this issue.

However, I would still consider the behavior of no-caret|tilde-version-(dev)Dependencies to be a bug?

Thanks for library though. This will help us to not have to track the package-lock.json file.

from npm-package-json-lint.

tclindner avatar tclindner commented on September 2, 2024

Hey @agvctm! Thank you for using the project. I'm excited that this project is helping you. I appreciate you putting some much detail in this issue. I've published v3.4.1 that should resolve the issue impacting no-caret|tilde-version-(dev)Dependencies. Let me know if you have any other issues.

from npm-package-json-lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.