Comments (3)
I think the problem is in the rule implementation:
const lint = function(packageJsonData, severity) {
const rangeSpecifier = '^';
if (packageJsonData.hasOwnProperty(nodeName) && areVersRangesValid(packageJsonData, nodeName, rangeSpecifier)) {
return new LintIssue(lintId, severity, nodeName, message);
}
return true;
};
If will only return the LintIssue if areVersRangesValid returns true. But that function will only return true if ALL the dependencies contain the caret. I want an error if ANY of the dependencies have the caret. It looks like the tilde and devDependencies of this have the same behavior.
If I have time. I'll try to get a PR together for it.
from npm-package-json-lint.
It turns out prefer-absolute-version-dependencies
and prefer-absolute-version-devDependencies
will accomplish what I need to do. So, I'll close this issue.
However, I would still consider the behavior of no-caret|tilde-version-(dev)Dependencies
to be a bug?
Thanks for library though. This will help us to not have to track the package-lock.json
file.
from npm-package-json-lint.
Hey @agvctm! Thank you for using the project. I'm excited that this project is helping you. I appreciate you putting some much detail in this issue. I've published v3.4.1 that should resolve the issue impacting no-caret|tilde-version-(dev)Dependencies. Let me know if you have any other issues.
from npm-package-json-lint.
Related Issues (20)
- feat: Check order of sub-properties
- Website not updated HOT 1
- Rule for allowing star w/ absolute version
- Update the command to run the CLI in the README file
- Unexpected behavior with the `--noConfigFiles` flag HOT 1
- [feat] no-absolute-version-peenDependencies
- Peer dep conflicts between npm-package-json-lint and the config-default package after latest update HOT 1
- overrides doesn't work with --configFile option HOT 1
- Types missing after upgrading from v5 to v6 HOT 3
- #595 release v6.0.2, please ! HOT 5
- [Enhancement Request] Improve messaging for `no-restricted-dependencies` HOT 1
- feat: add rule to disallow different versions of the same dependency in a mono-repo HOT 5
- feat: add scope for dependency rules HOT 1
- Website https://npmpackagejsonlint.org/ is down HOT 4
- feature request: "valid-values-scripts" rule HOT 1
- Rules link is broken HOT 1
- Feature request: `no-main` Rule
- Feature request: add whitelist for dependency rules
- Validating package.json againt its schema
- Export configuration type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from npm-package-json-lint.