[Idea]: Decouple from LaunchDarkly (add more adapters) about flopflip

[tdeekens]

1. This would probably involve renaming ld-wrapper to launchdarkly-adapter
2. This would include adding a localstorage-adapter
3. This would include having to pass in an adapter to ConfigureFlopFlip manually

Possible examples to configure adapters

import launchdarklyAdapter from '@flopflip/launchdarkly-adapter';

<ConfigureFlopFlip adapter={launchdarklyAdapter} adapterArgs={{ clientSideId: '123' }}>
  <App />
<ConfigureFlopFlip>

//..

import localstorageAdapter from '@flopflip/localstorage-adapter';

<ConfigureFlopFlip adapter={localstorageAdapter}>
  <App />
<ConfigureFlopFlip>

or something like

import launchdarklyAdapter from '@flopflip/launchdarkly-adapter';

launchdarklyAdapter.configure({ ldClientSideId: '123' })

<ConfigureFlopFlip adapter={launchdarklyAdapter}>
  <App />
<ConfigureFlopFlip>

All adapters would have to satisfy an API which could be roughly something like

• onStatusStateChange: Used for adapter to be able to communicate if they're ready, setup up and able interact with their "backend"
• onFlagsStateChange: Used to signal that the status of one or multiple flags has changed

[tdeekens]

The localstorage adapter would

1. Define a "constant" as a key to where flags are status data is persisted
2. Expose the API above (same for the launchdarkly-adapter`
3. Poll localstorage and "emit" changes though the onFlagsStateChange callback

[tdeekens]

Another adapter could be an url-adapter which reads the flag statuses from the url. Behind the scenes it could use something like https://github.com/ReactTraining/history

[tdeekens]

Another dapter could be an api-adapter which behind the scenes fetches flags from some service.

apiAdapter.configure({ url: 'http://my-great-service.com/flags', userKey: '123' })

It would then poll for changes taking the url http://my-great-service.com/flags/123. It compares the newly polled flags to the last and triggers the onFlagsStateChange callback to flush them into redux or the broadcasting mechanism.

[tdeekens]

Curious to what @dferber90 thinks if he finds time having a look 😅 .

[dferber90]

Adapters sound like a powerful concept.

Somehow seems like a perfect use-case for observable. But then again it would only raise more questions and we can achieve everything through functions already anyways. So I'd not use them.

After thinking about it a bit I'd prefer the version with adapterArgs as it provides a more natural to reconfigure the adapter in case information changes (like user logging out).

Maybe use a signature for the Adapter like this:

export default createAdapter = adapterArgs => (setStatusState, setFlagsState) => {
  setStatusState({ ready: true })
  setFlagsState({ FOO_FLAG: true })
}

Now either we only call the factory when adapterArgs' reference changes or we leave that to the adapter itself.

[tdeekens]

This will be part of #49. Thanks for all the feedback! Currently the launchdarkly-adapter has been ported while a memory-adapter has been created. The release will likely also contain a localstorage-adapter. Currently it feels like api-adapters are generally pretty bound to people's use cases, APIs and platforms. As a result I'd like to wait if someone actually needs on or if the implementation details settles.

[dferber90]

👍❤️