Comments (8)
- This would probably involve renaming
ld-wrapper
tolaunchdarkly-adapter
- This would include adding a
localstorage-adapter
- This would include having to pass in an adapter to
ConfigureFlopFlip
manually
Possible examples to configure adapters
import launchdarklyAdapter from '@flopflip/launchdarkly-adapter';
<ConfigureFlopFlip adapter={launchdarklyAdapter} adapterArgs={{ clientSideId: '123' }}>
<App />
<ConfigureFlopFlip>
//..
import localstorageAdapter from '@flopflip/localstorage-adapter';
<ConfigureFlopFlip adapter={localstorageAdapter}>
<App />
<ConfigureFlopFlip>
or something like
import launchdarklyAdapter from '@flopflip/launchdarkly-adapter';
launchdarklyAdapter.configure({ ldClientSideId: '123' })
<ConfigureFlopFlip adapter={launchdarklyAdapter}>
<App />
<ConfigureFlopFlip>
All adapters would have to satisfy an API which could be roughly something like
onStatusStateChange
: Used for adapter to be able to communicate if they're ready, setup up and able interact with their "backend"onFlagsStateChange
: Used to signal that the status of one or multiple flags has changed
from flopflip.
The localstorage adapter would
- Define a "constant" as a key to where flags are status data is persisted
- Expose the API above (same for the launchdarkly-adapter`
- Poll localstorage and "emit" changes though the
onFlagsStateChange
callback
from flopflip.
Another adapter could be an url-adapter
which reads the flag statuses from the url. Behind the scenes it could use something like https://github.com/ReactTraining/history
from flopflip.
Another dapter could be an api-adapter
which behind the scenes fetches flags from some service.
apiAdapter.configure({ url: 'http://my-great-service.com/flags', userKey: '123' })
It would then poll for changes taking the url http://my-great-service.com/flags/123
. It compares the newly polled flags to the last and triggers the onFlagsStateChange
callback to flush them into redux or the broadcasting mechanism.
from flopflip.
Curious to what @dferber90 thinks if he finds time having a look 😅 .
from flopflip.
Adapters sound like a powerful concept.
Somehow seems like a perfect use-case for observable
. But then again it would only raise more questions and we can achieve everything through functions already anyways. So I'd not use them.
After thinking about it a bit I'd prefer the version with adapterArgs
as it provides a more natural to reconfigure the adapter in case information changes (like user logging out).
Maybe use a signature for the Adapter like this:
export default createAdapter = adapterArgs => (setStatusState, setFlagsState) => {
setStatusState({ ready: true })
setFlagsState({ FOO_FLAG: true })
}
Now either we only call the factory when adapterArgs
' reference changes or we leave that to the adapter itself.
from flopflip.
This will be part of #49. Thanks for all the feedback! Currently the launchdarkly-adapter
has been ported while a memory-adapter
has been created. The release will likely also contain a localstorage-adapter
. Currently it feels like api-adapter
s are generally pretty bound to people's use cases, APIs and platforms. As a result I'd like to wait if someone actually needs on or if the implementation details settles.
from flopflip.
👍❤️
from flopflip.
Related Issues (20)
- If launchdarkly adapter cannot establish network connection, an error is thrown in `reconfigure` that cannot be handled. HOT 7
- Dependency installation error HOT 1
- A lot of babel dependecies are failing to install HOT 3
- Release notes HOT 4
- Warning from launchdarkly adapter HOT 12
- Unable to launch demo HOT 1
- Documentation for combine-adapters HOT 5
- Update examples for sdk.clientSideId change HOT 1
- Dependency Dashboard
- Using react-broadcast with localstorage adapter clears the localstorage all the time HOT 7
- Using react-broadcast with localstorage adapter clears localstorage on page reload HOT 8
- Cannot statically analyse `require(…, …)` caused by old version of `clone-deep`. HOT 3
- Next.js bug with React 18 HOT 4
- Default flags are ignored during the first render HOT 2
- ts-deepmerge v3 generates Source Map warnings HOT 2
- Typo: pollingIntervalMs is spelled pollingInteralMs
- Using `untoggledComponent` with `MemoryAdapter` in a vitest unit test causes OOM from re-render loop HOT 1
- Ability to pass attributes to SpiltIO adapter HOT 4
- <ToggleFeature> is typed as React.Component<any> HOT 1
- ConfigureFlopflip causes act error warnings in test environment HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flopflip.