Comments (9)
It may very well need to be fixed upstream. In my particular case, I am ok without the GC stats so maybe extracting those metrics into their own package. But that may be more of an annoyance than anything
But I get it, third (or nth) party audit problems are troublesome for everyone I just happened to "get it" from your dependency
from promster.
Thanks for reporting. Any suggestions on what we can do here specifically? Upon first sight it looks more like it needs fixing upstream?
from promster.
Yes, if I could I'd move away from a library not passing an audit but if it's a transitive dependency or a core dependency to the library I don't see how that's possible. Can you also open an issue upstream maybe?
from promster.
Yeah, I see the problem. I will try to identify where shall I open the issue. And let you know.
from promster.
So far:
Installing [email protected] -> no audit problems
I cannot install gc-stats because it cannot be built and there is no prebuilt binary. -> no audit problems
When I install @prompster/[email protected] -> the audit problems show off.
So, I am not really sure which upstream to create the issue in. no-pre-gyp has no issue and I cannot verify gc-stats because it does not build. Any hints?
from promster.
I also tried to install @promster/metrics with the --no-optional flag with no success, gc-stats still shows up in the package-lock and causes the audit problem
from promster.
gc-stats
is an optional dependency to the metrics packages which in turn is used by all integrations. To me it looks like gc-stats
usines mkdirp
which uses minimist
which has the issue. We could add a hard resolution to minimist here if it is fixed there. Do we know if it is?
from promster.
I am still looking for a solution, but some bigger fires need to be put down first 😉
from promster.
We finally decided to implement ourselves the metrics we need from fastify in a very non-generic manner.
Thanks for your help and your approach to metrics
from promster.
Related Issues (20)
- Express middleware skipping by request generates a TS error
- Permit per-metric custom buckets `createMetric` HOT 4
- Action Required: Fix Renovate Configuration
- 5 low vulnerabilities caused by optional dependency gc-stats HOT 19
- feature-request: Measure metrics from Electron HOT 4
- Dependency Dashboard
- Content length histograms for requests and responses HOT 1
- 10 High Severity vulnerabilities reported from node-gcstats dependency HOT 9
- `@promster/hapi` in version `6.1.0` causes an unhandled promise rejection HOT 5
- Add native support for GraphQL servers HOT 12
- @promster/hapi has warning about unmet peer dependency HOT 1
- `process.hrtime([time])` is no longer recommended for use HOT 1
- TYPE up gauge always returns 0 HOT 2
- Use NodeJS url module instead of deprecated transitive dependency HOT 3
- Splitting duration and size buckets in configuration HOT 2
- Fractional second values are truncated HOT 7
- Error: Added label "field_name" is not included in initial labelset HOT 2
- TPromsterOptions incorrect property HOT 2
- Socket level events are not detected HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promster.