Builds fails on 32 bit systems about minify

[tdewolff]

Thanks for the heads up! I believe we can just convert the 32 to 31, it's an upper limit on how long a slice can be (which is actually 1<<31 for 32 bit systems since Len() returns an int).

[tdewolff]

Can you try v2.20.29 and tell me if it works?

[misthios]

Hello,

the new versions gives the same error type but different value

# github.com/tdewolff/minify/v2/bindings/py
bindings/py/minify.go:28:12: invalid array length 1 << 31 (untyped int constant 2147483648)
bindings/py/minify.go:37:12: invalid array length 1 << 31 (untyped int constant 2147483648)
# github.com/tdewolff/minify/v2/bindings/js
bindings/js/minify.go:28:12: invalid array length 1 << 31 (untyped int constant 2147483648)
bindings/js/minify.go:37:12: invalid array length 1 << 31 (untyped int constant 2147483648)

[tdewolff]

Off-by-one error, please check v2.20.30!

[misthios]

Hello,

the 32bit build is unfortunately still broken.

1. the 2.20.30 commit only fixes one instance of the previous problem:

the goStringArray has the new -1, the goBytes still has 31 

2. after patching 1 we get a new problem which can be seen in the screenshot below (i only patched the python bindings for problem 1).

[tdewolff]

Must have been late, how does v2.20.31 do?

[misthios]

Hello,

I still get the same result unfortunately:

[tdewolff]

I really hope this is now fixed in v2.20.32, I have no idea why the address space for 32-bit systems is not math.MaxInt32-1 == 1<<31 - 1...

[misthios]

Hello,

2.20.32 seems to be working

Thank you :)