GithubHelp home page GithubHelp logo

Comments (3)

lopuhin avatar lopuhin commented on June 17, 2024

Nice catch!
I tried a negative slice in python 2, and it turns it into a non-negative slice, so it should be easy to support it here too. ok, it does not always happen :)
That slice operation should return a new FeatureNames object, right?

from eli5.

kmike avatar kmike commented on June 17, 2024

That slice operation should return a new FeatureNames object, right?

A good question; I think that's fine to return a list if returning FeatureUnion is harder to implement.

from eli5.

lopuhin avatar lopuhin commented on June 17, 2024

Hm, I didn't think about it at first (was going to make it return FeatureUnion), but in fact it will make implementation more complex - for example, we still might have missing entries that are handled by unkn_template, but now the index must be shifted.
So I agree, let's go with returning a list (or maybe a numpy slice if the underlying storage is a numpy array)

from eli5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.