GithubHelp home page GithubHelp logo

Comments (3)

RebeccaStevens avatar RebeccaStevens commented on June 26, 2024

This library can't merge non-basic objects out of the box.
See https://github.com/TehShrike/deepmerge#ismergeableobject

from deepmerge.

ZLY201 avatar ZLY201 commented on June 26, 2024

I found this in the source code:

function getKeys(target) {
	return Object.keys(target).concat(getEnumerableOwnPropertySymbols(target))
}

and something will be wrong with Object.keys

Object.keys(controller.signal)      // []

but for...in works fine

for (const key in controller.signal) {
    console.log(key);
}
/*
aborted
reason
onabort
throwIfAborted
addEventListener
dispatchEvent
removeEventListener
*/

May be should change to use for...in?

from deepmerge.

RebeccaStevens avatar RebeccaStevens commented on June 26, 2024

There are a few reason why for..in is a bad approach so I don't see that changing.

If you want a more modern version of this library, check out https://github.com/RebeccaStevens/deepmerge-ts

from deepmerge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.