Show a message when no logs available yet about cli

[chmouel]

@siamaksade how would you know if this is the actual output of the application it may be a stretch but usually when there is no logs I would expect the emptyness is valid, isnt it ?

[siamaksade]

Given that pipelineruns have always some infra containers (git clone, etc) running, is it possible for a pipelinerune to produce no logs at all?

…

On Tue, 25 Jun 2019 at 11:39, Chmouel Boudjnah ***@***.***> wrote: @siamaksade <https://github.com/siamaksade> how would you know if this is the actual output of the application it may be a stretch but usually when there is no logs I would expect the emptyness is valid, isnt it ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#117?email_source=notifications&email_token=AAI63FWFLEBQVFQPYOEKXYLP4HRV3A5CNFSM4HZTRROKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPVAJI#issuecomment-505368613>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI63FS3AD6DF5AEC6J2Q7TP4HRV3ANCNFSM4HZTRROA> .

[vdemeester]

@siamaksade yes, by default we don't show the infra logs (aka init logs), so my guess is there is a tiny tiny possibility of having no logs 👼. But in any case, we know the status of the pipelinerun (aka if it succeeded, failed, so we can act based on it)

[siamaksade]

@chmouel @vdemeester I see. Does the following make sense?

• If the pipelinerun is running and no logs: "No logs found yet..."
• If the pipelinerun is NOT running and no logs: "No logs found."

[chmouel]

sounds good, but what about for the second case to say instead :

Pipeline hasn't started...

[vdemeester]

If the pipelinerun is running and no logs: "No logs found yet..."

If -f is present, it will not return until it's not running, so there is not need for this case 👼 — if -fis not present, that's another story 😉

[chmouel]

can someone sum up the conclusion? i am confused 🥺

[siamaksade]

Here is a summary with a slight change :)

When -f present

• Logs command should wait for output (current implementation)

When -f is NOT present

• If pipelinerun is running and no logs available, logs command should wait (not return)
• If the pipelinerun is NOT running and no logs are available, the command should return and print: “No logs available.”