Show failure reason when a pipelinerun fails about cli

[piyush-garg]

Looks like we have to print the message from the condition of the specific task which failed, not from the pipeline run condition.

[piyush-garg]

/assign

[piyush-garg]

@siamaksade

If you see, the reason is getting printed on the status column in a bracket like

STARTED          DURATION    STATUS
41 seconds ago   0 seconds   Failed(PipelineInvalidGraph)

Do you mean printing the message in case of failure?

[siamaksade]

Yes, the message usually includes more details about the failure.

…

On Wed, 12 Jun 2019 at 09:28, Piyush Garg ***@***.***> wrote: @siamaksade <https://github.com/siamaksade> If you see the reason is getting printed on the status column in a bracket like STARTED DURATION STATUS 41 seconds ago 0 seconds Failed(PipelineInvalidGraph) Do you mean printing the message in case of failure? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#64?email_source=notifications&email_token=AAI63FTETSJZLOEB2RE7FMLP2CQQXA5CNFSM4HTXZG3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXPQDVA#issuecomment-501154260>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI63FTCB3EXPGG2ZEP7B4TP2CQQXANCNFSM4HTXZG3A> .

[siamaksade]

@piyush-garg

The error message still is not descriptive. tkn describe just says the task has failed:

$ tkn pr describe petclinic-deploy-pipeline-run-mmvst                                  
Name:           petclinic-deploy-pipeline-run-mmvst

Message
TaskRun petclinic-deploy-pipeline-run-mmvst-build-dp2fj has failed

While kubectl describe prints out the reason too:

$kubectl describe pipelinerun petclinic-deploy-pipeline-run-mmvst                                      
...
Status:
  Task Runs:
    Petclinic - Deploy - Pipeline - Run - Mmvst - Build - Dp 2 Fj:
      Pipeline Task Name:  build
      Status:
        Conditions:
          Last Transition Time:  2019-08-09T12:40:25Z
          Message:               Missing or invalid Task pipelines-demo/s2i-java-8: pods "petclinic-deploy-pipeline-run-mmvst-build-dp2fj-pod-c12670" is forbidden: unable to validate against any security context constraint: [spec.containers[3].securityContext.privileged: Invalid value: true: Privileged containers are not allowed spec.containers[5].securityContext.privileged: Invalid value: true: Privileged containers are not allowed]
          Reason:                CouldntGetTask

[piyush-garg]

@siamaksade Will take a look once more over this.

[piyush-garg]

@siamaksade It will be a great help if you can provide the complete kubectl describe pipelinerun petclinic-deploy-pipeline-run-mmvst output

[piyush-garg]

Hi, I tried to reproduce this, was not able to do, it is perfectly showing the message for me.

Let me know if you are able to create the scenario again.

[siamaksade]

@piyush-garg use this gist to reproduce it:
https://gist.github.com/siamaksade/9275d11a8f8b156c00c77c4a59cc6663

kubectl create -f all.yaml
kubectl create -f pr.yaml

And then compare the output the following commands:

tkn pr describe [pr-name]
kubectl describe pipelinerun [pr-name]