404 returned at localhost:9097 on master about dashboard

[dibbles]

hmmm - thought it might be because i did not change the web resource dir (not documented) ... but when changing to value: /go/src/github.com/tektoncd/dashboard/web .... i get the favicon but no page content

[a-roberts]

Logging what I've done: followed DEVELOPMENT.md on the commit hash 816fde0 which involved npm install, npm run build_ko, ko apply -f config then a port-forward.

I repeated these steps on master too and all is ok

Discussed with @dibbles who's suggested it may be a problem in our main README.md.

We are following the "non-ko" path which mentions docker building, replacing the image only in the yaml, then kubectl applying.

[dibbles]

Docs issue ... need to set web resource dir to ./web.

/assign

[steveodonovan]

See my comment here #99 (comment)

Shouldn't need to set that value

[a-roberts]

For anyone else following - we discussed this on Slack - we do indeed need it as we're not using ko for the "docker build, push, edit and kubectl apply" case. so we don't get the /var/run/ko/webfiles that's referenced in our deployment yaml.

Stephen raised a good question as to whether or not we want to have a separate deployment file now for Docker installs vs ko installs, and points out we will need such a file anyway when we have releases to reference.

This particular issue is fixed though so closing.