[proposal] consolidating to a single regexp engine about teler-waf

[dwisiswant0]

Added new candidate, https://github.com/AspieSoft/go-regex.

[dwisiswant0]

Current results

goos: linux
goarch: amd64
pkg: benchmark-regexp
cpu: 11th Gen Intel(R) Core(TM) i9-11900H @ 2.50GHz
GOMAXPROCS: 16

Click to toggle contents of bench code

package main

import (
	"fmt"
	"regexp"
	"testing"

	aspiesoft_regex "github.com/AspieSoft/go-regex/v8"
	grbit_pcre "github.com/GRbit/go-pcre"
	scorpionknifes_pcre "github.com/scorpionknifes/go-pcre"
)

const (
	patternNonPCRE = `(?i)(?:on(?:webkitanimationiteration|(?:(?:webkitanimation|(?:select|drag))s|t(?:ransition|ouch)s)tart|(?:webkit(?:transi|anima)tione|t(?:ransition|ouch)e|scrolle)nd|(?:beforescriptexecut|afterscriptexecut|(?:p(?:ointerrawupda|(?:opsta|as))|timeupda)t|b(?:eforetoggl|ounc)|(?:pointer|drag)leav|(?:pointer|touch)mov|mouse(?:lea|mo)v|pa(?:gehid|us)|resiz|clos)e|(?:mozfullscreen|fullscreen|(?:selec|dura)tion|hash|cue)change|unhandledrejection|a(?:nimation(?:iteration|cancel|start|end)|fterprint|uxclick)|transitioncancel|toggle\(popover\)|loaded(?:meta)?data|(?:canplaythroug|searc)h|(?:transitionru|(?:pointer|key)dow|mousedow|(?:focus|beg)i)n|pointerenter|(?:beforeunloa|invali|(?:seek|end)e|unloa)d|volumechange|c(?:(?:ontextmenu|ut)|opy)|(?:pointerov|drag(?:ent|ov))er|(?:(?:beforeinp|focuso)u|beforeprin|pointerou|beforecu|mouseou|submi|re(?:pea|se)|inpu)t|beforecopy|mouse(?:enter|over|up)|(?:mouse)?wheel|ratechange|(?:pointeru|keyu|dro)p|pageshow|progress|keypress|dblclick|canplay|dragend|playing|s(?:eeking|how)|message|s(?:croll|elect)|toggle|finish|change|focus|(?:erro|blu)r|click|start|drag|load|play|end))\s*?=`
	patternPCRE    = `(?:\/\w*\s*\)\s*\()|(?:\([\w\s]+\([\w\s]+\)[\w\s]+\))|(?:(?<!(?:mozilla\/\d\.\d\s))\([^)[]+\[[^\]]+\][^)]*\))|(?:[^\s!][{([][^({[]+[{([][^}\])]+[}\])][\s+",\d]*[}\])])|(?:"\)?\]\W*\[)|(?:=\s*[^\s:;]+\s*[{([][^}\])]+[}\])];)`
)

func BenchmarkCompileNonPCRE(b *testing.B) {
	var err error

	b.ResetTimer()
	b.Run("regexp", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = regexp.Compile(patternNonPCRE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())

	b.ResetTimer()
	b.Run("AspieSoft/go-regex", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = aspiesoft_regex.CompTry(patternNonPCRE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())

	b.ResetTimer()
	b.Run("GRbit/go-pcre", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = grbit_pcre.Compile(patternNonPCRE, grbit_pcre.MULTILINE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())

	b.ResetTimer()
	b.Run("scorpionknifes/go-pcre", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = scorpionknifes_pcre.Compile(patternNonPCRE, scorpionknifes_pcre.MULTILINE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())
}

func BenchmarkCompilePCRE(b *testing.B) {
	var err error

	b.ResetTimer()
	b.Run("AspieSoft/go-regex", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = aspiesoft_regex.CompTry(patternPCRE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())

	b.ResetTimer()
	b.Run("GRbit/go-pcre", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = grbit_pcre.Compile(patternPCRE, grbit_pcre.MULTILINE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())

	b.ResetTimer()
	b.Run("scorpionknifes/go-pcre", func(b *testing.B) {
		b.ReportAllocs()
		for i := 0; i < b.N; i++ {
			_, err = scorpionknifes_pcre.Compile(patternPCRE, scorpionknifes_pcre.MULTILINE)
			if err != nil {
				panic(err)
			}
		}
	})
	fmt.Println(b.Elapsed())
}

BenchmarkCompileNonPCRE

Engine	ns/op	B/op	allocs/op	elapsed
regexp	127972	131641	690	1.323665572s
AspieSoft/go-regex	29328	2322	3	1.384703177s
GRbit/go-pcre	21163	2744	6	1.330075384s
scorpionknifes/go-pcre	20630	12	2	1.735374764s

BenchmarkCompilePCRE

Engine	ns/op	B/op	allocs/op	elapsed
AspieSoft/go-regex	6647	465	3	1.122028641s
GRbit/go-pcre	4444	824	6	2.195591583s
scorpionknifes/go-pcre	4250	12	2	1.267168176s

[dwisiswant0]

Reopening as per #90 (comment).

[dwisiswant0]

I will mark this issue as completed, because - upon evaluating the trade-offs associated with migrating the built-in regexp engine within CustomRule and the inThreatRegexp utility (used by BadIPAddress and DirectoryBruteforce), there is no performance enhancements were observed.