GithubHelp home page GithubHelp logo

Comments (3)

smktpd avatar smktpd commented on June 11, 2024 1

You might be right. I don't understand some helm constructs, yet.
https://github.com/temporalio/helm-charts/blob/master/charts/temporal/templates/server-configmap.yaml#L60

    persistence:
      defaultStore: {{ $.Values.server.config.persistence.defaultStore }}
    {{- if or $.Values.elasticsearch.enabled $.Values.elasticsearch.external }}
      visibilityStore: es-visibility
    {{- else }}
      visibilityStore: visibility
    {{- end }}
    ...
      datastores:
        ...
        visibility:
          {{- if eq (include "temporal.persistence.driver" (list $ "default")) "sql" }}

includes temporal.persistence.driver, which is defined here:
https://github.com/temporalio/helm-charts/blob/master/charts/temporal/templates/_helpers.tpl#L144-L159
like this:

{{- define "temporal.persistence.driver" -}}
    {{- $global := index . 0 -}}
    {{- $store := index . 1 -}} 
    {{- $storeConfig := index $global.Values.server.config.persistence $store -}}
    {{- if $storeConfig.driver -}}
        {{- $storeConfig.driver -}}
    {{- else if $global.Values.cassandra.enabled -}}
        {{- print "cassandra" -}}
    {{- else if $global.Values.mysql.enabled -}}
        {{- print "sql" -}}
    {{- else if $global.Values.postgresql.enabled -}}
        {{- print "sql" -}}
    {{- else -}}
        {{- required (printf "Please specify persistence driver for %s store" $store) $storeConfig.driver -}}
    {{- end -}}
{{- end -}}

what does {{- $store := index . 1 -}} get resolved into?
still, it looks like temporal.persistence.driver is wrongly introduced key: there is no driver for 'persistence', there are only drivers for some stores, and since temporal basically has 3 possible stores (default + visibility, visibility-es)) - it should've instead been 3 different keys:
temporal.persistence.default.driver
temporal.persistence.visibility.driver
temporal.persistence.visibility_es.driver (I guess - is forbidden in the key paths)

from helm-charts.

smktpd avatar smktpd commented on June 11, 2024

Isn't that because you didn't set up visibilityStore (under persistence)?

from helm-charts.

np-we360 avatar np-we360 commented on June 11, 2024

Isn't that because you didn't set up visibilityStore (under persistence)?

That shouldn't be the case afaik. Please correct me if I'm wrong.

It defaults to "visibility" from my understanding of the template.

from helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.