GithubHelp home page GithubHelp logo

Comments (4)

Temzasse avatar Temzasse commented on May 27, 2024

Hi @benamm๐Ÿ‘‹

Can you describe your use case for the dynamic snap point in more detail? How should it work from your perspective?

I'll try to take a look at the snap point issue you mentioned when I have some free time to work on this project ๐Ÿ™‚

from react-modal-sheet.

shivamragnar avatar shivamragnar commented on May 27, 2024

Hey @Temzasse, I have a similar dynamic snap points use case. So i have two sets of snap points, which i pass as a prop using conditional operators, but i don't get the same animation as I would have got if the snap points were in same array.

Why I don't want these snap points in same array is because, when on a lower snap point, i do not want the sheet to go to a higher snap point. I wish if there was some way, where i can have the same animation as i get while switching snap points in my case where i am changing snap points array based on a condition.
Here is an example

<TheSheet
    isOpen={isOpen || isSending}
    initialSnap={initialSnap}
    onClose={onCloseOfSheet}
    disableDrag={disableDrag}
    snapPoints={ [heighestSnapPoint, 340, 0] }
 >
<TheSheet
   isOpen={isOpen || isSending}
   initialSnap={initialSnap}
   onClose={onCloseOfSheet}
   disableDrag={disableDrag}
   snapPoints={selectedUser.length ? [340, 0] : [heighestSnapPoint, 0]}
>

from react-modal-sheet.

Temzasse avatar Temzasse commented on May 27, 2024

What would be the expected result when the snap points array is dynamically changed? Should it animate to the snap point that exists in at the current active snap point index ๐Ÿค” What if the new array has less snap points than the previous one?

from react-modal-sheet.

shivamragnar avatar shivamragnar commented on May 27, 2024

The expected use cases are, say there are two pages in a sheet and both the pages have different set of snap points. For them to be used in the same sheet,

  • When the second UI is shown based on a boolean condition, it should snap to it's set of snap points.

  • Now to do that, there can be two solutions
    -> Give all the snap points in a single array and switch them according to which UI is rendered.
    -> Provide separate set of snap point arrays and switch between those arrays based on the which UI is rendered.

    The issue with first is
    -> We can't disable other snap points which are no more required, sheet can still use those snap points
    The second solution has
    -> No animation when the snap point array is changed. Like when for first time the sheet opens or when snap point changes
    from a single array, that kind of animation is not there in the sheet.

I hope this explanation helps @Temzasse :)

from react-modal-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.