Comments (2)
Hi @ScreamZ 👋🏻
The first scrolling issue can probably be solved with a body scroll locking library like this one. Framer Motion should handle body scroll locking automatically for draggable elements but it doesn't work all the time for some reason. So, I guess you can lock the body scroll every time you open the sheet and unlock it when the sheet closes.
I'm not sure if I should include a separate body scroll locking mechanism to this lib since it might not always be desirable to lock the scrolling when the sheet is open (eg. if you open the sheet on desktop etc). I would like to leave these kind of things to the end users. One place where automatic body scroll locking might make sense is the backdrop component since it most likely will alway cover the whole screen and thus you don't want to scroll anything behind it.
from react-modal-sheet.
I'm not sure if I should include a separate body scroll locking mechanism to this lib since it might not always be desirable to lock the scrolling when the sheet is open (eg. if you open the sheet on desktop etc). I would like to leave these kind of things to the end users. One place where automatic body scroll locking might make sense is the backdrop component since it most likely will alway cover the whole screen and thus you don't want to scroll anything behind it.
I guess too it doesn't belong to this library, but having a side note somewhere in the documentation giving this example could be nice. I'll use : https://mantine.dev/hooks/use-scroll-lock/ or this one from use-hook
https://github.com/streamich/react-use/blob/master/docs/useLockBodyScroll.md
from react-modal-sheet.
Related Issues (20)
- framer-motion is not tree-shaking HOT 1
- Unable to scroll behind the sheet, but able to click HOT 1
- Scroll flickering on iOS with Sheet.Scroller & inputs HOT 4
- Spring type animation
- Sheet is not opening on mobile browsers
- Sheet is not reopening in desktop Chrome HOT 3
- Allow style with Tailwind with className prop HOT 2
- initialSnap -34px bug HOT 2
- How do I implement a sticky footer? HOT 1
- Customer Header breaks dragging behavior
- Stacking sheets HOT 1
- TypeError: undefined is not an object (evaluating 'scrollable.scrollTop') HOT 1
- prevent Closing component HOT 2
- Sheet not closing on mobile HOT 8
- Bug on Safari Mobile, when switching the address bar up
- Bug: Mobile Safari input inside sheet stays behind when sheet moves HOT 4
- Bug: page overflow when mobile on screen keyboard is active (chrome) HOT 1
- Break tree shaking issue because of a "motion" HOT 3
- Close the sheet, but the component remains mounted with opacity 0. HOT 1
- Drag functionality with Scroller HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-modal-sheet.