GithubHelp home page GithubHelp logo

Comments (5)

Mr-Fullstack avatar Mr-Fullstack commented on May 27, 2024 1

can't get this working, this still works, would you have an example? please

from react-modal-sheet.

Temzasse avatar Temzasse commented on May 27, 2024

I guess it would be possible to make the whole sheet draggable but there are some caveats to that:

  • Scrolling would not work inside the sheet content anymore since framer-motion would capture all gestures and interpret them as dragging gestures.
  • The same issue applies to tap gestures so all taps to buttons/checkboxes/etc would not work properly.
  • Also things like native input range sliders would not work anymore.

If there is a way to implement this kind of draggability without breaking other tap/gesture based interactions I will definitely include it in the library.

Do you have some idea how this could be solved? I remember trying to figure this issue out when I initially created this lib but could not figure out a solution 😕

from react-modal-sheet.

Temzasse avatar Temzasse commented on May 27, 2024

I decided to test if Framer Motion had updated it's way of handling gestures/taps inside draggable targets and it seems that nowadays it's possible to make the whole container draggable 🎉 (or maybe I just messed this up initially somehow 🙈)

I will test this is a bit more and add it to the lib if everything works OK.

from react-modal-sheet.

Temzasse avatar Temzasse commented on May 27, 2024

@fairhat I added this feature to 1.1.0. Please try it out and report any related issues 🙏

from react-modal-sheet.

fairhat avatar fairhat commented on May 27, 2024

works, thx!

from react-modal-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.