Comments (11)
Also getting this error i fixed it by implementing onViewportBoxUpdate={() => {}}
on the Header
, Container
and Content
components.
Whilst it does work, I have an issue on some devices where closing the sheet doesn't remove the react-modal-sheet-container
div and leaves the backdrop covering the page rendering it non-interactable.
from react-modal-sheet.
What framer-motion and react-modal-sheet versions are you using?
from react-modal-sheet.
@Temzasse I'm using framer-motion 6.3.3
and react-modal-sheet 1.5.1
from react-modal-sheet.
I see similar issue on Sheet.Container, Sheet.Header and Sheet.Content components on both versions of framer-motion 6.3.3 and 6.2.1 with react-modal-sheet 1.5.1
Property 'onViewportBoxUpdate' is missing in type '{ children: Element[]; }' but required in type 'Pick<MotionProps, "style" | "onDrag" | "onDragEnd" | "onDragStart" | "onAnimationStart" | "inherit" | "transformTemplate" | "transformValues" | "variants" | "transition" | ... 35 more ... | "dragMomentum">'.ts
from react-modal-sheet.
@Temzasse same as @playaz87
framer-motion:^6.3.3
and react-modal-sheet:^1.5.1
from react-modal-sheet.
@Temzasse Any update on this?
from react-modal-sheet.
Unfortunately I don't have bandwidth to investigate this issue at the moment.
To me this sounds like a Framer Motion related issue since I'm basically just using the types from framer-motion
lib. Please check if there is a related issue in their repo. This could be an issue with your TS version as well 🤷♂️
My other hunch is that you might be having two versions of framer-motion
installed. Are you using npm's --legacy-peer-deps
to avoid getting duplicate peer deps?
from react-modal-sheet.
If, having installed the latest of both framer-motion and react-sheet-modal, react-sheet-modal has errors, then this is a bug within react-sheet-modal, and so it can only get fixed by the author or a contributor.
Downgrading framer-motion is not a good solution to this bug, but it's what I had to do in my case to get this library to work.
I wish that framer-motion would not release non-backwards-compatible updates, but it looks like they did, and so the only thing to do is fix the errors, as time-consuming as that is.
from react-modal-sheet.
@Johnrobmiller Which version of framer-motion
worked for you?
from react-modal-sheet.
I still have no clue what really caused the problem since everything works perfectly fine locally but when I build the lib the types have this extra onViewportBoxUpdate
prop that comes out of thin air 😅 It was somehow related to me using typeof
in the index file 🤷🏻♂️
Anyway, I think I found a way to fix the problem. Hopefully it works for you guys now 😊
This should be fixed in the latest patch release v1.5.2
.
from react-modal-sheet.
@Temzasse Thanks - can confirm I'm no longer getting the errors and it's now correctly working in Android Webview.
from react-modal-sheet.
Related Issues (20)
- Unable to scroll behind the sheet, but able to click HOT 1
- Scroll flickering on iOS with Sheet.Scroller & inputs HOT 4
- Spring type animation
- Sheet is not opening on mobile browsers
- Sheet is not reopening in desktop Chrome HOT 3
- Allow style with Tailwind with className prop HOT 2
- initialSnap -34px bug HOT 2
- How do I implement a sticky footer? HOT 1
- Customer Header breaks dragging behavior
- Stacking sheets HOT 1
- TypeError: undefined is not an object (evaluating 'scrollable.scrollTop') HOT 1
- prevent Closing component HOT 2
- Sheet not closing on mobile HOT 8
- Bug on Safari Mobile, when switching the address bar up
- Bug: Mobile Safari input inside sheet stays behind when sheet moves HOT 4
- Bug: page overflow when mobile on screen keyboard is active (chrome) HOT 1
- Break tree shaking issue because of a "motion" HOT 3
- Close the sheet, but the component remains mounted with opacity 0. HOT 1
- Drag functionality with Scroller HOT 1
- Project Still Maintained? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-modal-sheet.