GithubHelp home page GithubHelp logo

Comments (3)

thebusytypist avatar thebusytypist commented on May 12, 2024

Currently ParseErrorCode set is not complete.

By a explicit state machine implementation(branch TransitionTable), all errors can be captured on every transition to the error state.

from rapidjson.

thebusytypist avatar thebusytypist commented on May 12, 2024

Progress report:

Most of the functions have been implemented. Except that "May add a configurable limit of tree depth". I am considering adding a configurable limit on parsing stack size instead.

The state transitions are through unittested.

I also have a brief performance test for current implementation(36434b6).

On a i5 2400, 4GB Windows 7 x64 machine, with release32 build:

RapidJson.ReaderParse_DummyHandler_SSE42 (590 ms)
RapidJson.ReaderParseInsitu_DummyHandler_SSE42 (543 ms)
RapidJson.ReaderParseIterative_DummyHandler_SSE42 (656 ms)
RapidJson.ReaderParseIterativeInsitu_DummyHandler_SSE42 (503 ms)

I do not have a good explanation for these results. I guess change of memory access pattern may be the major cause.

A significant change is that the iterative parser will push state to the internal stack(GenericReader::stack_), which was only used for string parsing(GenericReader::ParseString) before.

I tried to separate the state stack, but did not see any impact on performance.

from rapidjson.

pah avatar pah commented on May 12, 2024

On an Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz, Linux 64-bit, GCC 4.8, I see the following:

  • [ OK ] RapidJson.ReaderParseInsitu_DummyHandler_SSE42 (550 ms)
    [ OK ] RapidJson.ReaderParseIterativeInsitu_DummyHandler_SSE42 (410 ms)
  • [ OK ] RapidJson.ReaderParse_DummyHandler_SSE42 (803 ms)
    [ OK ] RapidJson.ReaderParseIterative_DummyHandler_SSE42 (744 ms)

So it seems to be quite compiler-specific.

(The ordering of the tests could be more convenient to compare the variants, though).

from rapidjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.