Comments (5)
Hi @christopherbate! Thank you for reporting.
@ddunl Can you take a look please?
from mlir-hlo.
Thanks for bringing this to my attention! @christopherbate can you let me know if d391887 fixes this?
from mlir-hlo.
@ddunl Thanks for your response. This actually doesn't fix it (in LLVM External Project mode).
I added a print statement like this:
message(WARNING "MHLO DIRS: ${MLIR_HLO_SOURCE_DIR} ${MLIR_HLO_GEN_INCLUDE_DIR}")
target_include_directories(MhloDialect
PUBLIC
$<BUILD_INTERFACE:${MLIR_HLO_SOURCE_DIR}>
$<BUILD_INTERFACE:${MLIR_HLO_GEN_INCLUDE_DIR}>
)
and MLIR_HLO_GEN_INCLUDE_DIR
points to something like "build/llvm/tools/mlir-hlo/include" but actually the build tree under build/llvm/tools/mlir-hlo
doesn't have an include
directory.
from mlir-hlo.
Ah I was clearly not being careful enough when I made that change. I'll test a fix more thoroughly tomorrow. So sorry this is taking so long to get resolved!
from mlir-hlo.
Woops, didn't intend for this to be closed. Let me know if a170d81 fixes this. I had a hard time finding a project using LLVM External Project mode, but I was able to replicate the faulty path using that message(...)
line, and it appears to be fixed. Sorry about this!
from mlir-hlo.
Related Issues (20)
- Using StableHLO for ONNX to HLO conversion HOT 5
- Missing CMake deps for THLO and suspect layering HOT 8
- ld.lld: error: unable to find library -lMLIRTosa HOT 2
- Deduplicate reduction subcomputations when converting from MHLO to HLO HOT 1
- pretty print chlo.comparison* HOT 3
- Failure to compile broadcast_in_dim HOT 4
- 'mhlo/IR/hlo_ops.h' file not found HOT 7
- when build mlir-hlo-opt, there is error that symbolic cannot find HOT 1
- Move CMake CI for this repo to be publicly visible
- Missing empty canonicalization for reduce
- Inclusive language (sanity -> safety) HOT 4
- Failed to import repo as a third party dependency using bazel HOT 2
- 32-bit erf is inaccurate for x > 1 HOT 8
- `erfinv(1.)` should be `inf` HOT 1
- Missing legalization for `mhlo.scatter` to standard MLIR
- `tiling_softmax.cc#tilePartialSoftmax: undefined reference to `mlir::gml_st::isSimpleBcastReduction' HOT 1
- Build & Test sections in readme are inacurate
- Missing CMake Dependency
- mhlo.dot inferred shape is incompatible with return type HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mlir-hlo.