GithubHelp home page GithubHelp logo

Comments (5)

maxidl avatar maxidl commented on August 12, 2024 1

Hi,
I also stumbled across this issue. The pytorch re-implementation by @mlomnitz does indeed contain a commit in which this was adressed: mlomnitz/tcav_pytorch@c2b5b96

Maybe @mlomnitz remembers what his thought process was when changing it? I know it has been a while though...

Thanks in advance

from tcav.

hugoych avatar hugoych commented on August 12, 2024

Hi again,
@jameswex would you have any updates/explanations regarding the matter ?

Thanks in advance

from tcav.

jameswex avatar jameswex commented on August 12, 2024

@BeenKim can you please take a look? Thanks.

from tcav.

hugoych avatar hugoych commented on August 12, 2024

@jameswex Any update regarding the matter ? Thanks !

from tcav.

BeenKim avatar BeenKim commented on August 12, 2024

Sorry for this delayed response! We coded such that the two combination (loss and minus sign) would result in the same outcome. The code probably can be cleaned up to make this point clear.. sorry about that. Please reopen if your question remains!

from tcav.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.