Comments (24)
As a timesaver, I wrote up the process in a blog post (mostly because compared to GitHub, the process is poor).
from tensorflow.
Thanks! We'll use this bug to track the improvements to the contribution process, which we are working on improving.
from tensorflow.
👍
from tensorflow.
This Github Gerrit plugin could be evaluated
from tensorflow.
/cc @lucamilanesio for the plugin
from tensorflow.
Is this googlebot behaviour on other Google projects on github enought to let collect directly PRs here? If you want to get a pass with Gerrit you can also use the Gerrit github plugin I've already mentioned.
from tensorflow.
Also nice to evaluate is https://github.com/facebook/mention-bot
from tensorflow.
@vrv github history/log is full of "TensorFlow: Merging changes from internal". Not very readable.
from tensorflow.
You're correct. We're working on the process. It'll get better.
On Sat, Dec 12, 2015 at 1:57 AM bhack [email protected] wrote:
@vrv https://github.com/vrv github history/log is full of "TensorFlow:
Merging changes from internal". Not very readable.—
Reply to this email directly or view it on GitHub
#26 (comment)
.
from tensorflow.
@martinwicke Google
ExoPlayer like github management could be a starting point.
from tensorflow.
@bhack: fixed our scripts to have more informative / separate commits: https://github.com/tensorflow/tensorflow/commits/master
Hope that helps a bit.
from tensorflow.
@vrv If you don't rewrite the history and push force now some info will be lost forever here. Related, don't you like the Gerrit plugin I suggested? Why other Google projects like ExoPlayer seems to have a more "natural" relation with github?
from tensorflow.
The last commit seems to have the same description 091ed8c
from tensorflow.
@bhack: other projects probably have a more natural relation with github because they only have one source of truth. We have git, and we have our internal repository that we also contribute to actively, so the merge commit is unavoidable when trying to merge two different lineages.
That being said, now that we've moved to individual commits, the merge commit shouldn't be that bad. And it's basically the same as the merge commit from a pull request on github.
from tensorflow.
@vrv OK but why not the Gerrit github plugin? For the history in last commit I still see the same message see deff101
from tensorflow.
We are looking at that plugin as one potential option.
The last commit will always be a 'merge commit' message. BVLC/caffe@7953918 is the same, except we don't have a github pull request to reference, since the source isn't from github. Is there a better 'merge commit' message you would like?
from tensorflow.
@vrv BVLC/caffe@7953918 reference the related PR. I don't know so well Gerrit to tell you what reference get in the script to not let merge description be always the same.
from tensorflow.
@vrv: Should we just include the two commits hashes that were merged in the title?
from tensorflow.
For subscribers of this Issue the policy on PRs it is changed. Please see the new versions of CONTRIBUTING.md
from tensorflow.
@vrv In the caffe example you posted we have a description "Add ifdef in CuDNNConvolutionLayer for cuDNN v4". Can we recover some kind of info like this from Gerrit to put in the history. Actually I if want to move through the history I need to always check file changes of internal merges cause descriptions are uninformative.
from tensorflow.
The merge commit is merging a series of commits from our internal repository. 8b5d9ed is just the merge of the four previous commits, which each individually have the descriptions and change history you want.
For now, I'd suggest just skipping the "Merge commits from internal" commits when looking through the history. Maybe soon we can just have the merge commit message identify which commit hashes it merged so it's more easily linked.
from tensorflow.
Yes what I mean is if that upstream "gerrit commits" merges are assimilable to a PR as conceptual description. If so probably you could use this concept in the merge description. I.e. many projects ask to squash commits on PRs before merging. But if that are sparse uncorrelated commit I think not description make sense.
from tensorflow.
There is the equivalent of potentially many unrelated PRs in any such
merge, that's why it's hard to find a decent description for the sum of
them.
On Sat, Dec 19, 2015 at 10:42 bhack [email protected] wrote:
Yes what I mean is if that upstream "gerrit commits" merges are
assimilable to a PR as conceptual description. If so probably you could use
this concept in the merge description. I.e. many project ask to squash
commits on PRs before mergining. But if that are sparse uncorrelated commit
I think not description make sense.—
Reply to this email directly or view it on GitHub
#26 (comment)
.
from tensorflow.
We've switched to github and there are ongoing improvements to automated testing, etc. But the basics have been improved, so closing this catch-all bug.
from tensorflow.
Related Issues (20)
- Problem with tf.keras.layers.SimpleRNNCell HOT 1
- Inference results mismatch for Keras model before serialization and after serialization into SavedModel HOT 1
- Overfit and Underfit Notebook fails on compile_and_fit HOT 2
- Save and Load Notebook use a bad checkpoint_path file name HOT 4
- Segmentation Fault memcpy in tim::vx::TensorImpl::CopyDataToTensor TFLite with VX Delegate run
- incorrect result of sigmoid_cross_entropy_with_logits when input is np.inf HOT 2
- AutoGraph error: OP_REQUIRES failed at strided_slice_op.cc:266 HOT 1
- TensorFlow 2.17 for macOS x86_64 is not on PyPI HOT 4
- traceback issue HOT 1
- Accuracy not Improving TensorFlow Federated HOT 2
- Fail import tensorflow if rules_python is installed. HOT 2
- TypeError: `output_signature` must contain objects that are subclass of `tf.TypeSpec` but found <class 'list'> which is not. HOT 2
- Gradients can't be computed for keras embeddings HOT 4
- Hermetic Cuda doesn't respect really aarch64(Tegra devices) HOT 4
- check failed: !PyErr_Occurred() when constructing two uint64 tensors HOT 1
- TF_SelectV2Op gets legalized to TFL_SelectOp
- Wheels have different metadata on different platforms HOT 3
- TextVectorization returns 'int64' vs 'float32' in TF 2.7 / nightly + Training simple unigram/bigram models much slower than in 2.15 HOT 3
- How to pack TFRT into wheel? And use it in saved_model_cli. HOT 3
- Custom `tf.keras.metrics.Metric` example fails on GPU in TF 2.17 (but not on nightly): is it possible to get it to work on 2.17? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tensorflow.