GithubHelp home page GithubHelp logo

Comments (2)

joeykilpatrick avatar joeykilpatrick commented on June 2, 2024

I think there's a broader discussion to be had here. What should be displayed on abort? Here's what's happening today:

For prompts with an initial value, that value is printed.

{
  type: 'text',
  name: 'twitter',
  message: `What's your twitter handle?`,
  initial: `terkelg`,
}
...
✖ What's your twitter handle? … terkelg
{
  type: 'password',
  name: 'secret',
  message: 'Tell me a secret',
  initial: 'INITIAL'
}
...
✖ Tell me a secret … *******
{
  type: 'select',
  name: 'actor',
  message: 'Pick your favorite actor',
  initial: 0,
  choices: [
    { title: 'Cage' },
    { title: 'Gyllenhaal' },
  ],
}
...
✖ Pick your favorite actor › Cage

For those without initial values, nothing is printed.

{
  type: 'number',
  name: 'age',
  message: 'How old are you?',
}
...
✖ How old are you? … 

In the provided example for a confirm prompt, the initial value is set to true so "yes" is printed. If the initial value is false, then "no" is printed. Since the default initial value is false if one is not provided, then you still get "no" if you don't specify.

This behavior seems unintuitive. I would be in favor of always printing no value on abort for all prompt types like in the number example above. I would happy to submit a PR.

@terkelg

from prompts.

terkelg avatar terkelg commented on June 2, 2024

I agree @joeykilpatrick. Thank you

from prompts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.