Comments (12)
Haven't looked into it. No time at the moment. Give it a try!
from twmessagebarmanager.
Alright, I'll see what I can do.
Thanks for the quick reply.
from twmessagebarmanager.
I did not spend much time trying to fix it, but this little hack fixes the iOS 8 issue for me:
- (CGRect)orientFrame:(CGRect)frame
{
NSString *systemVersion = [UIDevice currentDevice].systemVersion;
NSUInteger systemInt = [systemVersion intValue];
if ( (UIDeviceOrientationIsLandscape([UIDevice currentDevice].orientation) || UIDeviceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) && systemInt < 8 )
{
frame = CGRectMake(frame.origin.x, frame.origin.y, frame.size.height, frame.size.width);
}
return frame;
}
I just simply added an iOS version number to the if conditional above.
from twmessagebarmanager.
Having the same issue in landscape, the bar is taking the whole view unfortunately.
from twmessagebarmanager.
have you tried to replace the orientFrame method with the one above? That fixed the problem for me.
from twmessagebarmanager.
Yes I tried, but problem is that when I turn my device, tap on the button which shows the message, it's shown as portrait
EDIT:
Tried again it works! Thanks man. Don't know why it was bugging me yesterday.
from twmessagebarmanager.
@ivanharmat do you want to submit a pull request with your patch?
from twmessagebarmanager.
sure. thanks. I'll get to it right now.
from twmessagebarmanager.
@terryworona I can't push my branch to git. It says "Permission to terryworona/TWMessageBarManager.git denied to ivanharmat."
Can you updated the code and create a new commit?
from twmessagebarmanager.
You'll have to issue a pull request @ivanharmat
See: https://help.github.com/articles/using-pull-requests
I can cherry pick your code but then you won't get any credit :)
from twmessagebarmanager.
OK @terryworona,
let me try again. I need to learn this anyway :)
from twmessagebarmanager.
@PhillipApps Please replace orientFrame method with this
-
(CGRect)orientFrame:(CGRect)frame
{
NSString *systemVersion = [UIDevice currentDevice].systemVersion;
NSUInteger systemInt = [systemVersion intValue];if ( (UIDeviceOrientationIsLandscape([UIDevice currentDevice].orientation) || [UIApplication sharedApplication].statusBarOrientation == UIInterfaceOrientationLandscapeLeft || [UIApplication sharedApplication].statusBarOrientation == UIInterfaceOrientationLandscapeRight) && systemInt < 8 )
{
frame = CGRectMake(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height);
}
return frame;
}
frame = CGRectMake(frame.origin.x, frame.origin.y, frame.size.height, frame.size.width); in original code which should be like this
frame = CGRectMake(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height);
thanks
from twmessagebarmanager.
Related Issues (20)
- Carthage Support
- Banner hidden by iPhone X notch
- Messages go above navigation bar (iOS 14)
- When there is SceneDelegate in app then it won't showing TWMessageBar
- Turn png images to code using PaintCode HOT 1
- Customization HOT 6
- Dismiss via swipe HOT 3
- Text is vertically not centered HOT 1
- Vertically align label with icon when description == nil or title == no HOT 1
- Swift support? HOT 1
- description not align icon HOT 1
- Swift Project HOT 2
- Some change to your project. HOT 1
- Allow to setup windowLevel
- use_frameworks! HOT 4
- Banner does not show in case of multiple push notification. HOT 1
- callback block not executed HOT 6
- Issue - Alert bellow status bar in iOS 9/10 HOT 1
- Customize TWMessageView numerics
- Do not hide, keep the popup unless until user taps on it? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twmessagebarmanager.