GithubHelp home page GithubHelp logo

Comments (7)

gtennis avatar gtennis commented on June 8, 2024

Now it works. Used @ivanharmat suggested fix: #59

from twmessagebarmanager.

gtennis avatar gtennis commented on June 8, 2024

It would be nice this fix to be merged into regular branch. Otherwise it will be overwritten next time we perform pod install. Usually I'm using dynamic pod versions therefore I need to add this change somewhere else. Tried to subclass TWMessageView and override method but TWMessageView is declared in manager class implementation therefore there no access to it.

from twmessagebarmanager.

terryworona avatar terryworona commented on June 8, 2024

@centurionas you want to submit a PR for this fix?

from twmessagebarmanager.

terryworona avatar terryworona commented on June 8, 2024

Pulled in this manually via commit: 581a116

from twmessagebarmanager.

gtennis avatar gtennis commented on June 8, 2024

Thanks @terryworona for excellent library. Now it works. Though I'm wondering why it's showing 1.7.2 version in cocoa pods and my pods file contains "pod 'TWMessageBarManager', '~> 1.7'". But when I run pod install it's written "Installing TWMessageBarManager 1.7.0 (was 1.7.0)". Should it be saying "1.7.2" when installing pod?

from twmessagebarmanager.

cdzombak avatar cdzombak commented on June 8, 2024

Though I'm wondering why it's showing 1.7.2 version in cocoa pods and my pods file contains "pod 'TWMessageBarManager', '~> 1.7'". But when I run pod install it's written "Installing TWMessageBarManager 1.7.0 (was 1.7.0)". Should it be saying "1.7.2" when installing pod?

What's in your Podfile.lock? If you have previously installed 1.7.0, pod install won't update it for you—either change your Podfile to require pod 'TWMessageBarManager', '~> 1.7.2' or run pod update.

from twmessagebarmanager.

terryworona avatar terryworona commented on June 8, 2024

@centurionas - change your podfile to:

pod 'TWMessageBarManager'

or

pod 'TWMessageBarManager', '~> 1.7.2'

from twmessagebarmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.