GithubHelp home page GithubHelp logo

Comments (16)

yedidyak avatar yedidyak commented on June 10, 2024

Hi, what platform is this about?

from react-native-camera-kit.

avlakin avatar avlakin commented on June 10, 2024

This happens on IOS. Did not test android.

from react-native-camera-kit.

gran33 avatar gran33 commented on June 10, 2024

Is this issue still relevant?

from react-native-camera-kit.

tiempham avatar tiempham commented on June 10, 2024

Same issue on IOS.

from react-native-camera-kit.

filipef101 avatar filipef101 commented on June 10, 2024

Android too, any update?

from react-native-camera-kit.

markhorn-dev avatar markhorn-dev commented on June 10, 2024

I just started using this package and can confirm this issue. ios iphone7plus. Camera definitely starts zoomed in (possibly 2x?) and not possible to zoom out, but can zoom in further and then back to (2x?).

Since this was reported first in sep 2016, and still persists in mar 2018, doesn't look like it's been acknowledged or up for a possible fix. It doesn't seem heavily reported, so maybe it only affects a small group. Does anyone have a workaround?

from react-native-camera-kit.

markhorn-dev avatar markhorn-dev commented on June 10, 2024

To add:

If you open the camera on iPhone and change between the views, square, photo, video, portrait, you can see they have different start zoom presets.

On ios it might have something to do with AVCaptureSessionPreset in CKCamera.m, but haven't had a chance to test it out. I'm hoping that's the issue.

from react-native-camera-kit.

filipef101 avatar filipef101 commented on June 10, 2024

Yes this happens! Most devs don't notice this

from react-native-camera-kit.

filipef101 avatar filipef101 commented on June 10, 2024

@gran33

from react-native-camera-kit.

markhorn-dev avatar markhorn-dev commented on June 10, 2024

Unfortunately, I wasn't able to fix this module but I wrapped and bridged the AVFoundation camera on apple dev and it works the way i need it to. I figured I would post my findings for reference.

I used a different interface AVCaptureDeviceDiscoverySession
I used AVCaptureDeviceTypeBuiltInWideAngleCamera as the device type
I used the preset AVCaptureSessionPresetPhoto
I unset the videoGravity = AVLayerVideoGravityResizeAspectFill;

This gave me 100% native view and FOV of the iPhone, as if I opened the native camera, and allows to take photos at 4032x3024 resolution, which is what I needed.

I do appreciate this project, it really gave me some insight on how to do some things, so thank you. :)

from react-native-camera-kit.

filipef101 avatar filipef101 commented on June 10, 2024

@MarkH-Dev Good to hear, no input on fixing the zoom on android?

from react-native-camera-kit.

FlaviooLima avatar FlaviooLima commented on June 10, 2024

I just made a PR #172 for this issue, can someone check if its ok? :)
I didn't find any problem but I don't use the whole package.

how to do a quick install:
npm install --save git+https://github.com/FlaviooLima/react-native-camera-kit#iOS-Zoom-Problem

or my master that has this fix and a few more.

npm install --save git+https://github.com/FlaviooLima/react-native-camera-kit

from react-native-camera-kit.

filipef101 avatar filipef101 commented on June 10, 2024

@FlaviooLima Great work! any idea what causes it on Android?

from react-native-camera-kit.

FlaviooLima avatar FlaviooLima commented on June 10, 2024

@filipef101 I didn't see any problem on Android devices. :/
I tested on Samsung s5 mini and One Plus 2.
Can you check if this is happening in my master? can you give me more details?

from react-native-camera-kit.

filipef101 avatar filipef101 commented on June 10, 2024

I use 1:1 camera view, but for example instagram uses 9:16 and has the same camera horizontal area as this package when in 1:1, the default camera app is like 3:4 and has more horizontal area so it does have some zoom, if you are using 9:16 you won't notice maybe.

from react-native-camera-kit.

FlaviooLima avatar FlaviooLima commented on June 10, 2024

@filipef101 I think you are 50% right in what you are saying if I understand it right.
The current bug in android is that the ratioOverlay color area is not showing and the photo taken it's not being cut to the suppose ratioOverlay area.

On iOS If you give some transparency to the ratioOverlay color you will see that the camera ratio is fixed, what you will see is that the ratioOverlay Color will give the idea that the ratio is not fixed but it is. After the photo is taken the photo ratio is passed to what you choose.

In Android, none of the above is happening.

Did I get it right ?? :)
if not please explain again :)

PS: I believe that on iOS there is still some zoom.

from react-native-camera-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.