Comments (3)
Not at the moment @sanderpick, because the JS libs no longer operate at this lower level API (they did when we had a full JS node). You are indeed correct though, that AddRecord was required in JS-land so that remote peers (js-threads) could create Records and then push them to the "remote" (go-threads). We don't do this at the moment, but there is a future where a JSON-RPC wrapped AddRecord API could be used from JS-land again...
I guess TL;DR not a constraint for JS right now.
from go-threads.
Well we can't remove the Prev
field in the cbor.CreateRecordConfig
because signing requires it. Guess we have to postpone to API change to have a log abstraction, for example, so we can call something like log.AppendRecord
in an intuitive way.
from go-threads.
Ah, makes sense. I was also wondering something related that @carsonfarmer may know about: Doesn't the threaddb
js lib need to "batch" add records that are already chained? I believe that was the origin of the AddRecord
API.
Instead of removing the API, we could probably fix the putRecords
logic to enforce that either:
- The first entry's
Prev
in the chain is HEAD - HEAD is somewhere in the chain
That should be enough to prevent creating orphaned chains.
from go-threads.
Related Issues (20)
- How to make sure open the same DB on different threadsd node?
- Collection with name collection can't be properly indexed HOT 4
- AddThread without creating a log HOT 2
- Make sure net/api/client.Subscribe loop ends gracefully when client is closing HOT 3
- Calling net.Record.PrevID() crashes when the client is closing HOT 2
- --- FAIL: TestModifiedSince (0.00s) HOT 1
- Lost records from the Subscribe() channel when records arrive concurrently HOT 1
- Found an interesting bug related to synchronisation of threads HOT 10
- feat: New API or method to `getRecords` _back_ from offset to limit
- Occasional CI timing out
- ReadFilter not working
- Proposal for go-threads improvements HOT 1
- Your Paper has a wrong definition of the CID in ipfs HOT 6
- ThreadDB Sharding and Replication? HOT 3
- DB API: Count only query option
- rpc error: code = Unknown desc = log already exists HOT 3
- How well does it scale? HOT 1
- Future of this project HOT 1
- General Question on ThreadDB functionality HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-threads.