Unhandled exception from std::stoi when modifying .xlsx about xlnt

[tfussell]

It's nice to have someone using something I wrote. I figured there'd be some problems like this showing up eventually.

Your analysis is correct. This code is trying to turn a relationship like "worksheets/sheet1.xml" into "1" and "worksheets/sheet2.xml" into "2". As you can see, it's not very flexible code. I'll try to come up with a better method soon.

[tfussell]

My latest commit, 8dc7342, should fix this problem. I've made the aforementioned code more robust (I hope). Please give it a try if you get a chance.

[Malvineous]

Almost! Sorry for the delay in testing this, many thanks for the update. Unfortunately it doesn't completely fix the problem, rather it moves it into workbook.cpp instead. Looks like there's a similar bit of code there too:

terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
...
#9  0x00007ffff7b3714b in xlnt::workbook::save (this=0x7fffffffe140, filename="book2.xlsx") at workbook.cpp:558
558                 std::size_t sheet_index = std::stoi(sheet_index_string.substr(0, sheet_index_string.find('.'))) - 1;

Hopefully it's just a copy-and-paste to fix that too?

[tfussell]

Copying and pasting this code is not very elegant and means I probably did something incorrect. All the same, it seems to be working now at least to the extent that I can test it.

[Malvineous]

Can you test with http://www.shikadi.net/files/book.xlsx with this change to sample1.cpp?

diff --git a/docs/samples/sample1.cpp b/docs/samples/sample1.cpp
index 3207292..4c754e9 100644
--- a/docs/samples/sample1.cpp
+++ b/docs/samples/sample1.cpp
@@ -18,7 +18,7 @@ int main()
                }
        }

-       xlnt::workbook workbook;
+       xlnt::workbook workbook = xlnt::reader::load_workbook("book.xlsx");

        for(int i = 0; i < 3; i++)
        {

[tfussell]

I tried loading it and saving it. I didn't have any problems, and the resulting copy appears identical (comparing in Google Docs since I don't have Office right now).

[tfussell]

It looks like the copy actually has two of each original worksheet and red font color is lost. I'll create issues for both of these.

[Malvineous]

That's weird, I still get a segfault when it tries to save the workbook again...

[tfussell]

Did you merge in the most recent commit, 690322? Sorry it's so complicated to get started. We'll get it working soon.

[Malvineous]

Oh my apologies! When you said that copying and pasting is not very elegant, I thought you weren't going to do that as a fix! I didn't realise you had already done it :-) Yes, now I update from the latest git version I no longer get a crash. Sorry about the confusion!

I do now get an error when opening the resulting file in Excel, but it looks like this is related to the formatting - dates go back to numbers etc. but I can't see any actual data loss - only the formatting. I'll let you open a new issue for that if you wish (maybe not necessary if it's a quick fix), and I'm happy to test again to confirm that's fixed too.

Thanks again for all your help! I really appreciate it.