Comments (3)
Oh, true, good point!
The check should not be for the gpu_mesh
field but for the self
, as we want to protect against accessing a field in an object that might have been already deleted...
e.g.
if ( self->gpu_mesh ) {
delete self->gpu_mesh;
}
should be:
if ( self) {
delete self->gpu_mesh;
}
(we still need to check for self
being valid before possibly accessing its gpu_mesh
field)
Would you like to send a PR? :)
from island.
update: this should be fixed now as of 32a012b
from island.
💭 Are you going to reconsider any more implementation details?
from island.
Related Issues (14)
- When are dot files created HOT 3
- global le::api in le_log HOT 2
- problem trying to compile examples HOT 2
- Failed to build for 18.04 HOT 5
- An error occurred while running example(hello world and ) on win10. HOT 1
- build error VK_MAKE_API_VERSION not declared HOT 2
- Compiling with Ninja on Windows HOT 5
- Please support MSYS2 MINGW64 HOT 1
- SPIRV and GLSLANG linker errors for examples HOT 8
- [le_mesh_generator] Redundant code HOT 2
- multiple windows and context sharing HOT 3
- Running on ubuntu HOT 10
- Windows compilation HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from island.