GithubHelp home page GithubHelp logo

Comments (3)

tgfrerer avatar tgfrerer commented on September 27, 2024

Oh, true, good point!

The check should not be for the gpu_mesh field but for the self, as we want to protect against accessing a field in an object that might have been already deleted...

e.g.

if ( self->gpu_mesh ) {
	delete self->gpu_mesh;
}

should be:

if ( self) {
	delete self->gpu_mesh;
}

(we still need to check for self being valid before possibly accessing its gpu_mesh field)

Would you like to send a PR? :)

from island.

tgfrerer avatar tgfrerer commented on September 27, 2024

update: this should be fixed now as of 32a012b

from island.

elfring avatar elfring commented on September 27, 2024

💭 Are you going to reconsider any more implementation details?

from island.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.