GithubHelp home page GithubHelp logo

Comments (7)

thomasgriffin avatar thomasgriffin commented on July 20, 2024

That is a really good suggestion. I will look into this and push out an update for it. I think Gary would agree that this is something that should be done.

from tgm-plugin-activation.

thomasgriffin avatar thomasgriffin commented on July 20, 2024

I consider this an improvement, not so much a bug, so it has been labeled as such. Gary, is this small enough to be a 2.1.1 commit?

from tgm-plugin-activation.

thomasgriffin avatar thomasgriffin commented on July 20, 2024

I'm guessing that we can hook into the switch_theme hook for this. I will make some tests and try it out.

from tgm-plugin-activation.

Japh avatar Japh commented on July 20, 2024

I'm not sure, but register_activation_hook() or register_deactivation_hook() might even be worthing looking into.

from tgm-plugin-activation.

thomasgriffin avatar thomasgriffin commented on July 20, 2024

As far as I am aware, those are only available for plugins, but I could be wrong because I've never really used either of them before. ;-)

from tgm-plugin-activation.

Japh avatar Japh commented on July 20, 2024

You may be right :) I've only used them in plugins myself

from tgm-plugin-activation.

GaryJones avatar GaryJones commented on July 20, 2024

@Japh - thanks for reporting, and yes, I completely agree.

@thomasgrffin - nice little fix, but yes, as a backwards-compatible improvement, rather than a bug fix, it should have gone under 2.2.0 rather than 2.1.1, but not to worry :-)

from tgm-plugin-activation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.