Carpets don't look like carpets when placed. about tgstation

I was just about to report this.

Can't reproduce.
Owner: ---

Lel

[caelaislinn]

Can you reproduce it in a private server?

[Aranclanos]

It just happened on sibyl1, removing the "cannot reproduce" tag

Revision:

e31c9ca

Server:

Locally run .dmb file

Problem description:

I crowbarred up this piece of carpet then replaced it. It appears as plating instead of carpet.

[SuperSayu]

The offending code is in game/turfs/simulated/floor.dm: update_icon(), not that it's hard to find;

update_icon, for carpet flooring anyway, tries to avoid extra updates and preserve the layout from mapping, by only running if the icon state is one of a small number of cases. This allows those cross squares you see in the chapel/HOP office to not be overridden.

Alternately, you could argue that make_carpet_floor (in the same file) should set the icon_state to one of those states so that it runs. However, if you do that, it won't update the nearby carpets when yours is added; in order to force nearby carpet to recalculate you'd have to change its icon state back to default before running update_icon()