[Improvements] Suggesting some improvements about watcher

[danieleperera]

In the https://github.com/Felix83000/Watcher/blob/master/Watcher/Watcher/site_monitoring/core.py

Instead of using a lot of If cases you could use something like.

def create_alert(id, site, new_ip, new_ip_second, score):
    ...
    ALERT = {     
            1:message_ip,    
            2:message_ip,    
            3:message_ips,    
            4:message_web,    
            5:message_web_ip,    
            6:message_web_ip,    
            7:message_web_ip,    
            8:message_mail    
            9:message_mail_ip,    
            10:message_mail_ip,    
            11:message_mail_ip,    
            12:message_mail_web,    
            13:message_mail_ip_web,    
            14:message_mail_ip_web,    
            15:message_mail_ip_web,     
        } 
if site.monitored:
    type_ = ALERT[id]
    try:
         new_alert = Alert.objects.create(site=site,
                                             type=type_,
                                             new_ip=new_ip or None,
                                             new_ip_second=new_ip_second or None,
                                             old_ip=site.ip or None,
                                             old_ip_second=site.ip_second or None)
        ...
    except Exception:
        ...

what do you think?

[Felix83000]

Thank you for your support! 💯

• The project is compatible with latest Docker & docker-compose version (We will add this to the documentation).

• We will consider to change core.py by services.py.

• We are not only saving TrendyWord. We save source post urls related to each TrendyWord. In fact, when you click on a new TrendyWord you have direct access to the source posts where the TrendyWord was found by Watcher.

• Rss-Bridge is, by default, configured with Twitter only, but users can use it for all other sources like: Facebook, DuckDuckGo, GoogleSearch...

  • To do such you need to add the new bridge needed in the Watcher/Rss-bridge/whitelist.txt file (We will add more documentation on that).

• We have planned to add a default RTIR number.

  • Expiry Date is not mandatory when you add a new DNS to monitoring.

• We have planned to add screenshot support in the future. Thanks for the link to Splash. 👍

  • We are already monitoring website content with TLSH which is a fuzzy hash algorithm.

Thanks for your contribution mate.
This helps!

[danieleperera]

I could but the Exception handling is not very clear maybe it's better if you push this improvement.

[Felix83000]

Great idea! May you pull request your work?
Thanks 👍