Comments (9)
This is on certain query: graph?g0.range_input=2w&g0.end_input=2017-11-23%2013%3A48&g0.expr=go_goroutines&g0.tab=0
(after some time and then 100% reproducible)
from thanos.
This started happening just after you started compaction again?
from thanos.
well not really. I was doing lot's of queries for different things and it started on certain query after some time.. so not sure if there is any correlation with compaction. (new compactor is running 1,5h)
from thanos.
Yes, did you ever see this happen before that though?
from thanos.
nope
from thanos.
I mean this ultimately just seems like some series entries get a good bit longer than the 4KB we expected.
It seems generally possible given we generated a lot of chunks initially with out 5s scrape interval. If you compact a week worth of those together, the series entry has to reference several hundred chunks.
13KB of chunk-indexing data for a single series in a single block actually makes me a bit worried :) But ultimately anything becomes worrisome if you keep the high resolution in long-term storage.
The answer here is basically to just bump the range we fetch per series.
from thanos.
I just hit it as well. It seems indeed to be non-deterministic for the same query over the same time range... that's rather odd though.
from thanos.
Got 'fixed' by bumping the maximum series size we are reading. Anything fully save will require upstream changes to the storage format.
from thanos.
Revisiting this as we saw some issues of violating this again e.g #552, plus investigate estimating postings
entry size as well here: #1839
Given just one error, it might still not worth to change. Just leaving the calculation for max size of series entry:
- Max varint lengths: https://github.com/golang/go/blob/master/src/encoding/binary/varint.go#L19
- max series entry size in bytes: 10 (max uvarint64) + 2 * 5 (max uvarint32) * a number of labels pairs + 10 (max uvarint64) + 3 * 10 (max uvarint64) * chunks
from thanos.
Related Issues (20)
- tools bucket: Add ability to discover external labels from prometheus address for `upload-blocks` HOT 1
- Thanos Sidecar - Flush Endpoint HOT 9
- Grafana only shows raw data from Thanos HOT 3
- Instance Principal Provider - Region issue
- Consider X-Forwarded-For on HTTP/GRPC Logging
- When I restart any Receive, the entire Seek cluster is unavailable, and the reboot can only be restored after the local data is fully understood HOT 2
- MaxTime is set to a too large number when doing larger latency requests? HOT 1
- Unauthorized errors for some endpoints with query-frontend HOT 1
- External labels not applied to alerts HOT 3
- 0.35: Panic with query mode distributed HOT 1
- query: Passing `THANOS-TENANT: <tenant>` header has no effect unless `--query.enforce-tenancy` is set HOT 3
- query: different results for rate function when not dedup or using implicit step interval HOT 7
- Thanos compactor causing huge memory spikes when compacting raw blocks HOT 2
- Ruler evaluation warning false alarm caused by engine warnings
- Expose when Rule alert labels are being overwritten by its --label(s)
- Read value of remote_user in Slow Query Logs of Query Frontend from a HTTP header HOT 3
- Thanos Receive doesn't announce external_labels which are set in hashrings.json when it works in routing and ingesting mode. HOT 1
- Issue with deduplication alogrithm in Thanos HOT 2
- Query Stats Returned with query including query bytes fetched HOT 4
- Max and min pointed at Sidecars not working on 0.35 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thanos.